2021-06-15 17:13:32

by Wei Yongjun

Subject: [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static

The sparse tool complains as follows:

sound/soc/codecs/hdmi-codec.c:750:25: warning:
symbol 'hdmi_codec_controls' was not declared. Should it be static?

This symbol is not used outside of hdmi-codec.c, so marks it static.

Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
sound/soc/codecs/hdmi-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index e0460a9bd17a..b61f980cabdc 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -747,7 +747,7 @@ static const struct snd_soc_dai_ops hdmi_codec_spdif_dai_ops = {
SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\
SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE)

-struct snd_kcontrol_new hdmi_codec_controls[] = {
+static struct snd_kcontrol_new hdmi_codec_controls[] = {
{
.access = SNDRV_CTL_ELEM_ACCESS_READ,
.iface = SNDRV_CTL_ELEM_IFACE_PCM,

2021-06-16 08:23:36

by Maxime Ripard

Subject: Re: [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static

On Tue, Jun 15, 2021 at 05:21:56PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> sound/soc/codecs/hdmi-codec.c:750:25: warning:
> symbol 'hdmi_codec_controls' was not declared. Should it be static?
>
> This symbol is not used outside of hdmi-codec.c, so marks it static.
>
> Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

Thanks!
Maxime