2021-06-17 02:50:30

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] regulator: sy7636a: Add terminate entry for platform_device_id tables

Make sure platform_device_id tables are NULL terminated.

Fixes: 8c485bedfb78 ("regulator: sy7636a: Initial commit")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/regulator/sy7636a-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
index c384c2b6ac46..672b7055131d 100644
--- a/drivers/regulator/sy7636a-regulator.c
+++ b/drivers/regulator/sy7636a-regulator.c
@@ -110,6 +110,7 @@ static int sy7636a_regulator_probe(struct platform_device *pdev)

static const struct platform_device_id sy7636a_regulator_id_table[] = {
{ "sy7636a-regulator", },
+ {},
};
MODULE_DEVICE_TABLE(platform, sy7636a_regulator_id_table);



2021-06-17 07:52:37

by Alistair Francis

[permalink] [raw]
Subject: Re: [PATCH -next] regulator: sy7636a: Add terminate entry for platform_device_id tables

On Thu, Jun 17, 2021, at 12:48 PM, Wei Yongjun wrote:
> Make sure platform_device_id tables are NULL terminated.
>
> Fixes: 8c485bedfb78 ("regulator: sy7636a: Initial commit")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Reviewed-by: Alistair Francis <[email protected]>

Alistair

> ---
> drivers/regulator/sy7636a-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index c384c2b6ac46..672b7055131d 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -110,6 +110,7 @@ static int sy7636a_regulator_probe(struct platform_device *pdev)
>
> static const struct platform_device_id sy7636a_regulator_id_table[] = {
> { "sy7636a-regulator", },
> + {},
> };
> MODULE_DEVICE_TABLE(platform, sy7636a_regulator_id_table);
>
>
>

2021-06-17 16:06:46

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] regulator: sy7636a: Add terminate entry for platform_device_id tables

On Thu, Jun 17, 2021 at 02:48:38AM +0000, Wei Yongjun wrote:
> Make sure platform_device_id tables are NULL terminated.

This doesn't apply against current code, please check and resend.

Attachments:
(No filename) (191.00 B)
 signature.asc (499.00 B)
 Download all attachments