2021-06-17 13:47:35

by Colin King

Subject: [PATCH] isofs: remove redundant continue statement

From: Colin Ian King <[email protected]>

The continue statement in the while-loop has no effect,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <[email protected]>
---
fs/isofs/dir.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
index b9e6a7ec78be..eb2f8273e6f1 100644
--- a/fs/isofs/dir.c
+++ b/fs/isofs/dir.c
@@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
break;
}
ctx->pos += de_len;
-
- continue;
}
if (bh)
brelse(bh);
--
2.31.1

2021-06-17 18:26:40

by Jan Kara

Subject: Re: [PATCH] isofs: remove redundant continue statement

On Thu 17-06-21 13:08:37, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The continue statement in the while-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <[email protected]>

Thanks! I've added the patch to my tree.

Honza

> ---
> fs/isofs/dir.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
> index b9e6a7ec78be..eb2f8273e6f1 100644
> --- a/fs/isofs/dir.c
> +++ b/fs/isofs/dir.c
> @@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
> break;
> }
> ctx->pos += de_len;
> -
> - continue;
> }
> if (bh)
> brelse(bh);
> --
> 2.31.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR