Hi Andrew,
> > index 0602d5d5d2ee..dc2d31321cbd 100644
> > --- a/drivers/net/ethernet/freescale/fec.h
> > +++ b/drivers/net/ethernet/freescale/fec.h
> > @@ -29,6 +29,10 @@
> > */
> > #define FEC_IEVENT 0x004 /* Interrupt event reg */
> > #define FEC_IMASK 0x008 /* Interrupt mask reg */
> > +#ifdef CONFIG_FEC_MTIP_L2SW
> > +#define FEC_MTIP_R_DES_ACTIVE_0 0x018 /* L2 switch Receive
> > descriptor reg */ +#define FEC_MTIP_X_DES_ACTIVE_0 0x01C /*
> > L2 switch Transmit descriptor reg */ +#endif
>
> Please don't scatter #ifdef everywhere.
>
> In this case, the register exists, even if the switch it not being
> used, so there is no need to have it conditional.
+1
>
> > #include <asm/cacheflush.h>
> >
> > #include "fec.h"
> > +#ifdef CONFIG_FEC_MTIP_L2SW
> > +#include "./mtipsw/fec_mtip.h"
> > +#endif
>
> Why not just include it all the time?
Ok.
>
> Andrew
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]