2021-06-29 12:19:28

by Nicolas Saenz Julienne

[permalink] [raw]
Subject: [PATCH] drm/vc4: hdmi: Limit noise when deferring snd card registration

We don't want to print an error message each time
devm_snd_soc_register_card() returns -EPROBE_DEFER, the function will
most likely succeed some time in the future, once the missing resources
are available. So use dev_err_probe(), which will redirect the messages
to the debug log level in such case.

Signed-off-by: Nicolas Saenz Julienne <[email protected]>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 04936cd6db8c..32da45821d3a 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1575,7 +1575,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
snd_soc_card_set_drvdata(card, vc4_hdmi);
ret = devm_snd_soc_register_card(dev, card);
if (ret)
- dev_err(dev, "Could not register sound card: %d\n", ret);
+ dev_err_probe(dev, ret, "Could not register sound card\n");

return ret;

--
2.31.1


2021-07-06 09:18:56

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] drm/vc4: hdmi: Limit noise when deferring snd card registration

On Tue, Jun 29, 2021 at 02:17:23PM +0200, Nicolas Saenz Julienne wrote:
> We don't want to print an error message each time
> devm_snd_soc_register_card() returns -EPROBE_DEFER, the function will
> most likely succeed some time in the future, once the missing resources
> are available. So use dev_err_probe(), which will redirect the messages
> to the debug log level in such case.
>
> Signed-off-by: Nicolas Saenz Julienne <[email protected]>

Applied, thanks
Maxime


Attachments:
(No filename) (483.00 B)
signature.asc (235.00 B)
Download all attachments