2021-07-06 15:12:20

by Colin King

[permalink] [raw]
Subject: [PATCH][next] pwm: core: remove redundant assignment to pointer pwm

From: Colin Ian King <[email protected]>

The pointer pwm is being initialized with a value that is never read and
it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/pwm/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index a28c8639af5b..35e894f4a379 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -846,7 +846,7 @@ EXPORT_SYMBOL_GPL(of_pwm_get);
*/
static struct pwm_device *acpi_pwm_get(const struct fwnode_handle *fwnode)
{
- struct pwm_device *pwm = ERR_PTR(-ENODEV);
+ struct pwm_device *pwm;
struct fwnode_reference_args args;
struct pwm_chip *chip;
int ret;
--
2.31.1


2021-07-06 16:02:56

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH][next] pwm: core: remove redundant assignment to pointer pwm

Hello,

[adding Andy and Rafael to Cc:]

On Tue, Jul 06, 2021 at 04:11:32PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer pwm is being initialized with a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/pwm/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index a28c8639af5b..35e894f4a379 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -846,7 +846,7 @@ EXPORT_SYMBOL_GPL(of_pwm_get);
> */
> static struct pwm_device *acpi_pwm_get(const struct fwnode_handle *fwnode)
> {
> - struct pwm_device *pwm = ERR_PTR(-ENODEV);
> + struct pwm_device *pwm;
> struct fwnode_reference_args args;
> struct pwm_chip *chip;
> int ret;

LGTM:

Acked-by: Uwe Kleine-K?nig <[email protected]>

and if you want:

Fixes: e5c38ba9f281 ("pwm: core: Reuse fwnode_to_pwmchip() in ACPI case")

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachments:
(No filename) (1.31 kB)
 signature.asc (499.00 B)
 Download all attachments

2021-07-06 16:29:48

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH][next] pwm: core: remove redundant assignment to pointer pwm

On Tue, Jul 06, 2021 at 05:58:20PM +0200, Uwe Kleine-K?nig wrote:

> [adding Andy and Rafael to Cc:]

Thanks.

> On Tue, Jul 06, 2021 at 04:11:32PM +0100, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > The pointer pwm is being initialized with a value that is never read and
> > it is being updated later with a new value. The initialization is
> > redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <[email protected]>
> > ---
> > drivers/pwm/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> > index a28c8639af5b..35e894f4a379 100644
> > --- a/drivers/pwm/core.c
> > +++ b/drivers/pwm/core.c
> > @@ -846,7 +846,7 @@ EXPORT_SYMBOL_GPL(of_pwm_get);
> > */
> > static struct pwm_device *acpi_pwm_get(const struct fwnode_handle *fwnode)
> > {
> > - struct pwm_device *pwm = ERR_PTR(-ENODEV);
> > + struct pwm_device *pwm;

I would move it after the next line...

> > struct fwnode_reference_args args;

...i.e. here

struct pwm_device *pwm;

> > struct pwm_chip *chip;
> > int ret;
>
> LGTM:
>
> Acked-by: Uwe Kleine-K?nig <[email protected]>
>
> and if you want:
>
> Fixes: e5c38ba9f281 ("pwm: core: Reuse fwnode_to_pwmchip() in ACPI case")

With or without above comment addressed,
Reviewed-by: Andy Shevchenko <[email protected]>

Thanks for spotting and fixing this!

--
With Best Regards,
Andy Shevchenko