2021-07-08 21:40:44

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the amdgpu tree

---

Hi all,

In commit

b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")

Fixes tag

Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)

has these problem(s):

- Subject has leading but no trailing quotes
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2021-07-09 07:44:46

by Dan Carpenter

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

---

On Fri, Jul 09, 2021 at 07:37:11AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")
>
> Fixes tag
>
> Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)
>
> has these problem(s):
>
> - Subject has leading but no trailing quotes
> Just use
> git log -1 --format='Fixes: %h ("%s")'

Oops. Sorry. I've created a fixes.sh like you say.

#!/bin/bash

git log -1 --format='Fixes: %h ("%s")' $*

regards,
dan carpenter

2021-07-09 13:06:15

by Alex Deucher

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

---

On Fri, Jul 9, 2021 at 3:43 AM Dan Carpenter <[email protected]> wrote:
>
> On Fri, Jul 09, 2021 at 07:37:11AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")
> >
> > Fixes tag
> >
> > Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)
> >
> > has these problem(s):
> >
> > - Subject has leading but no trailing quotes
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
>
> Oops. Sorry. I've created a fixes.sh like you say.
>

Fixed up locally.

Alex

> #!/bin/bash
>
> git log -1 --format='Fixes: %h ("%s")' $*
>
> regards,
> dan carpenter