2021-07-13 07:41:18

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH v3 3/5] s390/ccwgroup: Drop if with an always false condition

The driver core only calls a bus remove callback when there is a driver.
So dev->driver is never NULL and the check can safely be removed.

Reviewed-by: Cornelia Huck <[email protected]>
Acked-by: Vineeth Vijayan <[email protected]>
Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/s390/cio/ccwgroup.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index 9748165e08e9..a6aeab1ea0ae 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -444,8 +444,6 @@ static int ccwgroup_remove(struct device *dev)
struct ccwgroup_device *gdev = to_ccwgroupdev(dev);
struct ccwgroup_driver *gdrv = to_ccwgroupdrv(dev->driver);

- if (!dev->driver)
- return 0;
if (gdrv->remove)
gdrv->remove(gdev);

--
2.30.2