2021-07-15 09:09:10

by Clark Wang

Subject: [PATCH 1/4] i3c: master: svc: move module reset behind clk enable

Reset I3C module will R/W its regs, so enable its clocks first.

Signed-off-by: Clark Wang <[email protected]>
---
drivers/i3c/master/svc-i3c-master.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 879e5a64acaf..c25a372f6820 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1381,8 +1381,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)

master->dev = dev;

- svc_i3c_master_reset(master);
-
ret = clk_prepare_enable(master->pclk);
if (ret)
return ret;
@@ -1419,6 +1417,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, master);

+ svc_i3c_master_reset(master);
+
/* Register the master */
ret = i3c_master_register(&master->base, &pdev->dev,
&svc_i3c_master_ops, false);
--
2.25.1

2021-07-15 22:55:06

by Miquel Raynal

Subject: Re: [PATCH 1/4] i3c: master: svc: move module reset behind clk enable

Hi Clark,

Clark Wang <[email protected]> wrote on Thu, 15 Jul 2021 16:24:10
+0800:

> Reset I3C module will R/W its regs, so enable its clocks first.
>
> Signed-off-by: Clark Wang <[email protected]>

Reviewed-by: Miquel Raynal <[email protected]>

Thanks,
Miquèl