2021-05-28 17:35:54

by Masahiro Yamada

Subject: [PATCH] firmware_loader: remove unneeded 'comma' macro

Commit 553671b76859 ("firmware_loader: Fix labels with comma for builtin
firmware") added this line, which was unneeded.

The macro 'comma' is defined in scripts/Kbuild.include.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/base/firmware_loader/builtin/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/base/firmware_loader/builtin/Makefile b/drivers/base/firmware_loader/builtin/Makefile
index 5fa7ce3745a0..101754ad48d9 100644
--- a/drivers/base/firmware_loader/builtin/Makefile
+++ b/drivers/base/firmware_loader/builtin/Makefile
@@ -8,7 +8,6 @@ fwdir := $(addprefix $(srctree)/,$(filter-out /%,$(fwdir)))$(filter /%,$(fwdir))
obj-y := $(addsuffix .gen.o, $(subst $(quote),,$(CONFIG_EXTRA_FIRMWARE)))

FWNAME = $(patsubst $(obj)/%.gen.S,%,$@)
-comma := ,
FWSTR = $(subst $(comma),_,$(subst /,_,$(subst .,_,$(subst -,_,$(FWNAME)))))
ASM_WORD = $(if $(CONFIG_64BIT),.quad,.long)
ASM_ALIGN = $(if $(CONFIG_64BIT),3,2)
--
2.27.0

2021-06-11 00:06:38

by Luis Chamberlain

Subject: Re: [PATCH] firmware_loader: remove unneeded 'comma' macro

On Sat, May 29, 2021 at 02:34:03AM +0900, Masahiro Yamada wrote:
> Commit 553671b76859 ("firmware_loader: Fix labels with comma for builtin
> firmware") added this line, which was unneeded.
>
> The macro 'comma' is defined in scripts/Kbuild.include.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Acked-by: Luis Chamberlain <[email protected]>

Luis

2021-07-15 22:18:59

by Luis Chamberlain

Subject: Re: [PATCH] firmware_loader: remove unneeded 'comma' macro

On Sat, May 29, 2021 at 02:34:03AM +0900, Masahiro Yamada wrote:
> Commit 553671b76859 ("firmware_loader: Fix labels with comma for builtin
> firmware") added this line, which was unneeded.
>
> The macro 'comma' is defined in scripts/Kbuild.include.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Acked-by: Luis Chamberlain <[email protected]>

Luis