2021-07-16 15:50:19

by Tudor Ambarus

Subject: [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node

sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
which does not come populated on board by default. Since the spi0 node
does not have any child populated by default, thus no user on
sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
which reads the values of the pulled downed lines, unrecognizing the flash:

spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00

Signed-off-by: Tudor Ambarus <[email protected]>
---
arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 0b3ad1b580b8..046796c5b9b0 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -38,16 +38,6 @@ uart0: serial@f8004000 {
status = "okay";
};

- spi0: spi@f8010000 {
- cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
- status = "okay";
- m25p80@0 {
- compatible = "atmel,at25df321a";
- spi-max-frequency = <50000000>;
- reg = <0>;
- };
- };
-
i2c0: i2c@f8014000 {
i2c-digital-filter;
status = "okay";
--
2.25.1

2021-07-16 19:16:00

by Nicolas Ferre

Subject: Re: [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node

On 16/07/2021 at 17:47, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Since the spi0 node
> does not have any child populated by default, thus no user on
> sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
> which reads the values of the pulled downed lines, unrecognizing the flash:
>
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
>
> Signed-off-by: Tudor Ambarus <[email protected]>

Acked-by: Nicolas Ferre <[email protected]>

Queued in at91-dt.

Regards,
Nicolas

> ---
> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..046796c5b9b0 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -38,16 +38,6 @@ uart0: serial@f8004000 {
> status = "okay";
> };
>
> - spi0: spi@f8010000 {
> - cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> - status = "okay";
> - m25p80@0 {
> - compatible = "atmel,at25df321a";
> - spi-max-frequency = <50000000>;
> - reg = <0>;
> - };
> - };
> -
> i2c0: i2c@f8014000 {
> i2c-digital-filter;
> status = "okay";
>


--
Nicolas Ferre