2021-07-20 13:01:34

by Tang Bin

Subject: [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code

Use the defined variable "dev" to make the code cleaner.

Co-developed-by: Zhang Shengju <[email protected]>
Signed-off-by: Zhang Shengju <[email protected]>
Signed-off-by: Tang Bin <[email protected]>
---
drivers/iio/adc/fsl-imx25-gcq.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index d28976f21..01fe5b137 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -192,11 +192,11 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev,
*/
priv->vref[MX25_ADC_REFP_INT] = NULL;
priv->vref[MX25_ADC_REFP_EXT] =
- devm_regulator_get_optional(&pdev->dev, "vref-ext");
+ devm_regulator_get_optional(dev, "vref-ext");
priv->vref[MX25_ADC_REFP_XP] =
- devm_regulator_get_optional(&pdev->dev, "vref-xp");
+ devm_regulator_get_optional(dev, "vref-xp");
priv->vref[MX25_ADC_REFP_YP] =
- devm_regulator_get_optional(&pdev->dev, "vref-yp");
+ devm_regulator_get_optional(dev, "vref-yp");

for_each_child_of_node(np, child) {
u32 reg;
@@ -298,7 +298,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
int ret;
int i;

- indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv));
+ indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
if (!indio_dev)
return -ENOMEM;

--
2.20.1.windows.1

2021-07-24 15:26:21

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code

On Tue, 20 Jul 2021 20:59:45 +0800
Tang Bin <[email protected]> wrote:

> Use the defined variable "dev" to make the code cleaner.
>
> Co-developed-by: Zhang Shengju <[email protected]>
> Signed-off-by: Zhang Shengju <[email protected]>
> Signed-off-by: Tang Bin <[email protected]>

Applied.

Thanks,

Jonathan

> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index d28976f21..01fe5b137 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -192,11 +192,11 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev,
> */
> priv->vref[MX25_ADC_REFP_INT] = NULL;
> priv->vref[MX25_ADC_REFP_EXT] =
> - devm_regulator_get_optional(&pdev->dev, "vref-ext");
> + devm_regulator_get_optional(dev, "vref-ext");
> priv->vref[MX25_ADC_REFP_XP] =
> - devm_regulator_get_optional(&pdev->dev, "vref-xp");
> + devm_regulator_get_optional(dev, "vref-xp");
> priv->vref[MX25_ADC_REFP_YP] =
> - devm_regulator_get_optional(&pdev->dev, "vref-yp");
> + devm_regulator_get_optional(dev, "vref-yp");
>
> for_each_child_of_node(np, child) {
> u32 reg;
> @@ -298,7 +298,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> int ret;
> int i;
>
> - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv));
> + indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
> if (!indio_dev)
> return -ENOMEM;
>