2021-07-20 15:47:11

by Colin King

Subject: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block

From: Colin Ian King <[email protected]>

Currently the { } braces are missing around an if block causing subsequent
code after the return to become unreachable. Fix this by adding the
missing { }.

Addresses-Coverity: ("Structurally dead code")
Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs")
Signed-off-by: Colin Ian King <[email protected]>
---
sound/isa/opti9xx/opti92x-ad1848.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 8988de8cca96..4beeb32fe2a7 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -1096,9 +1096,10 @@ static int snd_opti9xx_pnp_probe(struct pnp_card_link *pcard,
if (error)
return error;
error = snd_opti9xx_read_check(card, chip);
- if (error)
+ if (error) {
snd_printk(KERN_ERR "OPTI chip not found\n");
return error;
+ }
error = snd_opti9xx_probe(card);
if (error < 0)
return error;
--
2.31.1

2021-07-20 15:49:01

by Takashi Iwai

Subject: Re: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block

On Tue, 20 Jul 2021 17:37:41 +0200,
Colin King wrote:
>
> From: Colin Ian King <[email protected]>
>
> Currently the { } braces are missing around an if block causing subsequent
> code after the return to become unreachable. Fix this by adding the
> missing { }.
>
> Addresses-Coverity: ("Structurally dead code")
> Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs")
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi