2021-07-20 16:24:28

by Colin King

Subject: [PATCH][next] ALSA: sc6000: Fix incorrect sizeof operator

From: Colin Ian King <[email protected]>

Static analysis is warning that the sizeof being used is should be
of *vport and not vport. Although these are the same size it is not
a portable assumption to assume this is true for all cases. Fix this
by using sizeof(*vport).

Addresses-Coverity: ("Sizeof not portable")
Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
Signed-off-by: Colin Ian King <[email protected]>
---
sound/isa/sc6000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
index 6236c4fa766a..44c05b55fc15 100644
--- a/sound/isa/sc6000.c
+++ b/sound/isa/sc6000.c
@@ -552,7 +552,7 @@ static int snd_sc6000_probe(struct device *devptr, unsigned int dev)


err = snd_devm_card_new(devptr, index[dev], id[dev], THIS_MODULE,
- sizeof(vport), &card);
+ sizeof(*vport), &card);
if (err < 0)
return err;

--
2.31.1

2021-07-20 16:32:57

by Takashi Iwai

Subject: Re: [PATCH][next] ALSA: sc6000: Fix incorrect sizeof operator

On Tue, 20 Jul 2021 18:17:07 +0200,
Colin King wrote:
>
> From: Colin Ian King <[email protected]>
>
> Static analysis is warning that the sizeof being used is should be
> of *vport and not vport. Although these are the same size it is not
> a portable assumption to assume this is true for all cases. Fix this
> by using sizeof(*vport).
>
> Addresses-Coverity: ("Sizeof not portable")
> Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
> Signed-off-by: Colin Ian King <[email protected]>

Thanks. I have another patch to drop this allocation (it's just a
pointer, so no need for kmalloc, really), but since your patch is
correct, I'll rebase on yours.


Takashi