2021-07-21 08:28:51

by Andy Shevchenko

Subject: [PATCH v1 1/1] net: wwan: iosm: Switch to use module_pci_driver() macro

Eliminate some boilerplate code by using module_pci_driver() instead of
init/exit, moving the salient bits from init into probe.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/net/wwan/iosm/iosm_ipc_pcie.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
index 7f7d364d3a51..2fe88b8be348 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
@@ -479,6 +479,7 @@ static struct pci_driver iosm_ipc_driver = {
},
.id_table = iosm_ipc_ids,
};
+module_pci_driver(iosm_ipc_driver);

int ipc_pcie_addr_map(struct iosm_pcie *ipc_pcie, unsigned char *data,
size_t size, dma_addr_t *mapping, int direction)
@@ -560,21 +561,3 @@ void ipc_pcie_kfree_skb(struct iosm_pcie *ipc_pcie, struct sk_buff *skb)
IPC_CB(skb)->mapping = 0;
dev_kfree_skb(skb);
}
-
-static int __init iosm_ipc_driver_init(void)
-{
- if (pci_register_driver(&iosm_ipc_driver)) {
- pr_err("registering of IOSM PCIe driver failed");
- return -1;
- }
-
- return 0;
-}
-
-static void __exit iosm_ipc_driver_exit(void)
-{
- pci_unregister_driver(&iosm_ipc_driver);
-}
-
-module_init(iosm_ipc_driver_init);
-module_exit(iosm_ipc_driver_exit);
--
2.30.2

2021-07-21 08:43:06

by Loic Poulain

Subject: Re: [PATCH v1 1/1] net: wwan: iosm: Switch to use module_pci_driver() macro

On Wed, 21 Jul 2021 at 10:20, Andy Shevchenko
<[email protected]> wrote:
>
> Eliminate some boilerplate code by using module_pci_driver() instead of
> init/exit, moving the salient bits from init into probe.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Loic Poulain <[email protected]>

2021-07-21 21:04:44

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v1 1/1] net: wwan: iosm: Switch to use module_pci_driver() macro

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 21 Jul 2021 11:20:58 +0300 you wrote:
> Eliminate some boilerplate code by using module_pci_driver() instead of
> init/exit, moving the salient bits from init into probe.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/net/wwan/iosm/iosm_ipc_pcie.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)

Here is the summary with links:
- [v1,1/1] net: wwan: iosm: Switch to use module_pci_driver() macro
https://git.kernel.org/netdev/net-next/c/7f8b20d0deed

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html