2021-07-21 10:12:13

by Colin King

[permalink] [raw]
Subject: [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd

From: Colin Ian King <[email protected]>

The pointer pcmd is being initialized with a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/lpfc/lpfc_sli.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index c34240819d92..47dd13719901 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -10129,8 +10129,6 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq,
bf_set(wqe_ebde_cnt, &wqe->xmit_els_rsp.wqe_com, 0);
bf_set(wqe_rsp_temp_rpi, &wqe->xmit_els_rsp,
phba->sli4_hba.rpi_ids[ndlp->nlp_rpi]);
- pcmd = (uint32_t *) (((struct lpfc_dmabuf *)
- iocbq->context2)->virt);
if (phba->fc_topology == LPFC_TOPOLOGY_LOOP) {
bf_set(els_rsp64_sp, &wqe->xmit_els_rsp, 1);
bf_set(els_rsp64_sid, &wqe->xmit_els_rsp,
--
2.31.1


2021-07-27 03:07:23

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd


Colin,

> The pointer pcmd is being initialized with a value that is never read,
> the assignment is redundant and can be removed.

Applied to 5.15/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-07-29 03:41:07

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd

On Wed, 21 Jul 2021 10:53:50 +0100, Colin King wrote:

> The pointer pcmd is being initialized with a value that is never
> read, the assignment is redundant and can be removed.

Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: lpfc: remove redundant assignment to pointer pcmd
https://git.kernel.org/mkp/scsi/c/ff2d86d04d26

--
Martin K. Petersen Oracle Linux Engineering