2021-07-21 21:02:44

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4

From: Arnd Bergmann <[email protected]>

The other rtlwifi drivers already have this, but r8723bs
was converted to the generic implementation without adding
the select:

ERROR: modpost: "arc4_crypt" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: modpost: "arc4_setkey" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!

Fixes: 1b11e893eda0 ("staging: rtl8723bs: replace private arc4 encryption with in-kernel one")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/staging/rtl8723bs/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
index a88467334dac..7eae820eae3b 100644
--- a/drivers/staging/rtl8723bs/Kconfig
+++ b/drivers/staging/rtl8723bs/Kconfig
@@ -5,6 +5,7 @@ config RTL8723BS
depends on m
select WIRELESS_EXT
select WEXT_PRIV
+ select CRYPTO_LIB_ARC4
help
This option enables support for RTL8723BS SDIO drivers, such as
the wifi found on the 1st gen Intel Compute Stick, the CHIP
--
2.29.2


2021-07-21 21:04:52

by Fabio Aiuto

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4

On Wed, Jul 21, 2021 at 05:35:44PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The other rtlwifi drivers already have this, but r8723bs
> was converted to the generic implementation without adding
> the select:
>
> ERROR: modpost: "arc4_crypt" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
> ERROR: modpost: "arc4_setkey" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
>
> Fixes: 1b11e893eda0 ("staging: rtl8723bs: replace private arc4 encryption with in-kernel one")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/staging/rtl8723bs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index a88467334dac..7eae820eae3b 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -5,6 +5,7 @@ config RTL8723BS
> depends on m
> select WIRELESS_EXT
> select WEXT_PRIV
> + select CRYPTO_LIB_ARC4
> help
> This option enables support for RTL8723BS SDIO drivers, such as
> the wifi found on the 1st gen Intel Compute Stick, the CHIP
> --
> 2.29.2
>

Acked-by: Fabio Aiuto <[email protected]>

thank you,

fabio