2021-07-21 21:03:21

by Bjorn Andersson

Subject: [PATCH] phy: qcom-qmp: Fix sc8180x PCIe definition

A copy paste error was snuck into the patch going upstream that made the
SC8180x PCIe PHY use the SM8250 serdes table, but while this works
there's some differences in the tables (and the SC8180x was left
dangling). So correct the SC8180x definition to use the SC8180x serdes
table.

Fixes: f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index b2ab20cd8ef5..cb2bf0590991 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -3519,7 +3519,7 @@ static const struct qmp_phy_cfg sc8180x_pciephy_cfg = {
.type = PHY_TYPE_PCIE,
.nlanes = 1,

- .serdes_tbl = sm8250_qmp_pcie_serdes_tbl,
+ .serdes_tbl = sc8180x_qmp_pcie_serdes_tbl,
.serdes_tbl_num = ARRAY_SIZE(sm8250_qmp_pcie_serdes_tbl),
.tx_tbl = sc8180x_qmp_pcie_tx_tbl,
.tx_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_tx_tbl),
--
2.29.2

2021-07-22 09:11:43

by Vinod Koul

Subject: Re: [PATCH] phy: qcom-qmp: Fix sc8180x PCIe definition

On 21-07-21, 09:30, Bjorn Andersson wrote:
> A copy paste error was snuck into the patch going upstream that made the
> SC8180x PCIe PHY use the SM8250 serdes table, but while this works
> there's some differences in the tables (and the SC8180x was left
> dangling). So correct the SC8180x definition to use the SC8180x serdes
> table.

Applied, thanks

--
~Vinod