2021-07-21 23:28:59

by Dmitry Osipenko

[permalink] [raw]
Subject: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR

The regulator coupler drivers now use regulator-driver API function that
isn't available during compile-testing. Make regulator coupler drivers
dependent on CONFIG_REGULATOR in Kconfig.

Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Dmitry Osipenko <[email protected]>
---

Changelog:

v2: - No changes. Re-sending to Arnd Bergmann and [email protected].

drivers/soc/tegra/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index db49075b1946..1224e1c8c2c9 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
select PL310_ERRATA_769419 if CACHE_L2X0
select SOC_TEGRA_FLOWCTRL
select SOC_TEGRA_PMC
- select SOC_TEGRA20_VOLTAGE_COUPLER
+ select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
select TEGRA_TIMER
help
Support for NVIDIA Tegra AP20 and T20 processors, based on the
@@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
select PL310_ERRATA_769419 if CACHE_L2X0
select SOC_TEGRA_FLOWCTRL
select SOC_TEGRA_PMC
- select SOC_TEGRA30_VOLTAGE_COUPLER
+ select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
select TEGRA_TIMER
help
Support for NVIDIA Tegra T30 processor family, based on the
@@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
config SOC_TEGRA20_VOLTAGE_COUPLER
bool "Voltage scaling support for Tegra20 SoCs"
depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
+ depends on REGULATOR

config SOC_TEGRA30_VOLTAGE_COUPLER
bool "Voltage scaling support for Tegra30 SoCs"
depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
+ depends on REGULATOR
--
2.32.0


2021-07-22 10:51:55

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR


On 22/07/2021 00:26, Dmitry Osipenko wrote:
> The regulator coupler drivers now use regulator-driver API function that
> isn't available during compile-testing. Make regulator coupler drivers
> dependent on CONFIG_REGULATOR in Kconfig.
>
> Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
>
> Changelog:
>
> v2: - No changes. Re-sending to Arnd Bergmann and [email protected].
>
> drivers/soc/tegra/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index db49075b1946..1224e1c8c2c9 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
> select PL310_ERRATA_769419 if CACHE_L2X0
> select SOC_TEGRA_FLOWCTRL
> select SOC_TEGRA_PMC
> - select SOC_TEGRA20_VOLTAGE_COUPLER
> + select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
> select TEGRA_TIMER
> help
> Support for NVIDIA Tegra AP20 and T20 processors, based on the
> @@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
> select PL310_ERRATA_769419 if CACHE_L2X0
> select SOC_TEGRA_FLOWCTRL
> select SOC_TEGRA_PMC
> - select SOC_TEGRA30_VOLTAGE_COUPLER
> + select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
> select TEGRA_TIMER
> help
> Support for NVIDIA Tegra T30 processor family, based on the
> @@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
> config SOC_TEGRA20_VOLTAGE_COUPLER
> bool "Voltage scaling support for Tegra20 SoCs"
> depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
> + depends on REGULATOR
>
> config SOC_TEGRA30_VOLTAGE_COUPLER
> bool "Voltage scaling support for Tegra30 SoCs"
> depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
> + depends on REGULATOR
>


Acked-by: Jon Hunter <[email protected]>

Thanks!
Jon

--
nvpublic

2021-08-02 14:36:16

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR

On Thu, Jul 22, 2021 at 02:26:16AM +0300, Dmitry Osipenko wrote:
> The regulator coupler drivers now use regulator-driver API function that
> isn't available during compile-testing. Make regulator coupler drivers
> dependent on CONFIG_REGULATOR in Kconfig.
>
> Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
>
> Changelog:
>
> v2: - No changes. Re-sending to Arnd Bergmann and [email protected].
>
> drivers/soc/tegra/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Seeing that Arnd hasn't picked this up yet, I've now applied it to the
Tegra tree and plan to send out a PR for v5.14 later this week.

Thierry


Attachments:
(No filename) (794.00 B)
signature.asc (849.00 B)
Download all attachments

2021-08-02 16:23:12

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR

On Mon, Aug 02, 2021 at 05:05:01PM +0200, Arnd Bergmann wrote:
> On Mon, Aug 2, 2021 at 5:03 PM Arnd Bergmann <[email protected]> wrote:
> > On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <[email protected]> wrote:
> >
> > If you have other fixes that are already in your fixes branch
> ... that you want to have in rc5, please send them soon, as I'm going
> to prepare that pull request in a few days.
>
> I'll probably do another one for -rc6 though.

Okay, will do. Thanks.

Thierry


Attachments:
(No filename) (504.00 B)
signature.asc (849.00 B)
Download all attachments