2021-07-22 05:35:47

by Srikandan, Nandhini

Subject: [“PATCH” 1/2] dt-bindings: spi: Add bindings for Intel Thunder Bay SoC

From: Nandhini Srikandan <[email protected]>

Add documentation for SPI controller in Intel Thunder Bay SoC.

Signed-off-by: Nandhini Srikandan <[email protected]>
---
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
index ca91201a9926..88532bf8ba85 100644
--- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
+++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
@@ -61,6 +61,8 @@ properties:
- const: snps,dw-apb-ssi
- description: Intel Keem Bay SPI Controller
const: intel,keembay-ssi
+ - description: Intel Thunder Bay SPI Controller
+ const: intel,thunderbay-ssi
- description: Baikal-T1 SPI Controller
const: baikal,bt1-ssi
- description: Baikal-T1 System Boot SPI Controller
--
2.17.1

2021-07-22 17:14:27

by Serge Semin

Subject: Re: [“PATCH” 1/2 ] dt-bindings: spi: Add bindings for Intel Thunder Bay SoC

On Thu, Jul 22, 2021 at 01:33:57PM +0800, [email protected] wrote:
> From: Nandhini Srikandan <[email protected]>
>

> Add documentation for SPI controller in Intel Thunder Bay SoC.

In the driver-part of the patchset you said that the reset control
is required for this controller. Then the bindings file needs to be
accordingly altered. See the way it's done in the "allOf:" block here.

If it isn't required then this part looks ok to me.

Regards,
-Sergey

>
> Signed-off-by: Nandhini Srikandan <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index ca91201a9926..88532bf8ba85 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -61,6 +61,8 @@ properties:
> - const: snps,dw-apb-ssi
> - description: Intel Keem Bay SPI Controller
> const: intel,keembay-ssi
> + - description: Intel Thunder Bay SPI Controller
> + const: intel,thunderbay-ssi
> - description: Baikal-T1 SPI Controller
> const: baikal,bt1-ssi
> - description: Baikal-T1 System Boot SPI Controller
> --
> 2.17.1
>