2021-07-23 09:18:13

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] drm/hisilicon/hibmc: remove an unused variable

From: Arnd Bergmann <[email protected]>

A recent patch left an unused variable in place that needs to be
removed:

drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c: In function 'hibmc_unload':
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:252:35: error: unused variable 'priv' [-Werror=unused-variable]
252 | struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);

Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f73a8e0ea12e..610fc8e135f9 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)

static int hibmc_unload(struct drm_device *dev)
{
- struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
struct pci_dev *pdev = to_pci_dev(dev->dev);

drm_atomic_helper_shutdown(dev);
--
2.29.2


2021-07-23 18:22:33

by Thomas Zimmermann

[permalink] [raw]
Subject: Re: [PATCH] drm/hisilicon/hibmc: remove an unused variable

Hi

Am 23.07.21 um 11:16 schrieb Arnd Bergmann:
> From: Arnd Bergmann <[email protected]>
>
> A recent patch left an unused variable in place that needs to be
> removed:
>
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c: In function 'hibmc_unload':
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:252:35: error: unused variable 'priv' [-Werror=unused-variable]
> 252 | struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
>
> Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")

Thanks for the patch. The issue has meanwhile been fixed in drm-misc-next.

Best regards
Thomas

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


Attachments:
OpenPGP_signature (855.00 B)
OpenPGP digital signature