2021-07-19 20:30:44

by Rob Herring

Subject: [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings

The graph schema doesn't allow custom properties on endpoint nodes for
'#/properties/port' and '#/$defs/port-base' should be used instead. This
doesn't matter until 'unevaluatedProperties' support is implemented.

Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Krishna Manikandan <[email protected]>
Cc: [email protected]
Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 6 ++++--
.../bindings/display/msm/dsi-controller-main.yaml | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index d101233ae17f..07b20383cbca 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -37,7 +37,8 @@ properties:

properties:
port@0:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description: Video port for MIPI DSI Channel-A input

properties:
@@ -57,7 +58,8 @@ properties:
- const: 4

port@1:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description: Video port for MIPI DSI Channel-B input

properties:
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 76348b71f736..de23cab9b5f1 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -77,7 +77,8 @@ properties:

properties:
port@0:
- $ref: "/schemas/graph.yaml#/properties/port"
+ $ref: "/schemas/graph.yaml#/$defs/port-base"
+ unevaluatedProperties: false
description: |
Input endpoints of the controller.
properties:
@@ -92,7 +93,8 @@ properties:
enum: [ 0, 1, 2, 3 ]

port@1:
- $ref: "/schemas/graph.yaml#/properties/port"
+ $ref: "/schemas/graph.yaml#/$defs/port-base"
+ unevaluatedProperties: false
description: |
Output endpoints of the controller.
properties:
--
2.27.0

2021-07-23 21:19:14

by Rob Herring

Subject: Re: [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings

On Mon, 19 Jul 2021 13:50:01 -0600, Rob Herring wrote:
> The graph schema doesn't allow custom properties on endpoint nodes for
> '#/properties/port' and '#/$defs/port-base' should be used instead. This
> doesn't matter until 'unevaluatedProperties' support is implemented.
>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Rob Clark <[email protected]>
> Cc: Sean Paul <[email protected]>
> Cc: Marek Vasut <[email protected]>
> Cc: Krishna Manikandan <[email protected]>
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 6 ++++--
> .../bindings/display/msm/dsi-controller-main.yaml | 6 ++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>

Applied, thanks!

2021-07-23 21:27:27

by Rob Herring

Subject: Re: [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings

On Mon, Jul 19, 2021 at 1:57 PM Sam Ravnborg <[email protected]> wrote:
>
> Hi Rob,
> On Mon, Jul 19, 2021 at 01:50:01PM -0600, Rob Herring wrote:
> > The graph schema doesn't allow custom properties on endpoint nodes for
> > '#/properties/port' and '#/$defs/port-base' should be used instead. This
> > doesn't matter until 'unevaluatedProperties' support is implemented.
> >
> > Cc: David Airlie <[email protected]>
> > Cc: Daniel Vetter <[email protected]>
> > Cc: Rob Clark <[email protected]>
> > Cc: Sean Paul <[email protected]>
> > Cc: Marek Vasut <[email protected]>
> > Cc: Krishna Manikandan <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Rob Herring <[email protected]>
> Acked-by: Sam Ravnborg <[email protected]>

Thanks. FYI, your mail only went thru on dri-devel, but not DT or LKML lists.

Rob