2021-07-25 15:24:00

by Jason Wang

Subject: [PATCH] net: qed: remove unneeded return variables

Some return variables are never changed until function returned.
These variables are unneeded for their functions. Therefore, the
unneeded return variables can be removed safely by returning their
initial values.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index e81dd34a3cac..dc93ddea8906 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -741,7 +741,6 @@ static int
qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
{
struct qed_dcbx_mib_meta_data data;
- int rc = 0;

memset(&data, 0, sizeof(data));
data.addr = p_hwfn->mcp_info->port_addr + offsetof(struct public_port,
@@ -750,7 +749,7 @@ qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
data.size = sizeof(struct lldp_config_params_s);
qed_memcpy_from(p_hwfn, p_ptt, data.lldp_local, data.addr, data.size);

- return rc;
+ return 0;
}

static int
@@ -810,7 +809,6 @@ static int
qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
{
struct qed_dcbx_mib_meta_data data;
- int rc = 0;

memset(&data, 0, sizeof(data));
data.addr = p_hwfn->mcp_info->port_addr +
@@ -819,7 +817,7 @@ qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
data.size = sizeof(struct dcbx_local_params);
qed_memcpy_from(p_hwfn, p_ptt, data.local_admin, data.addr, data.size);

- return rc;
+ return 0;
}

static int qed_dcbx_read_mib(struct qed_hwfn *p_hwfn,
--
2.32.0

2021-07-26 12:23:23

by Shai Malin

Subject: RE: [PATCH] net: qed: remove unneeded return variables

On Sunday, July 25, 2021 6:14 PM, Jason Wang <[email protected]> wrote:
> Some return variables are never changed until function returned.
> These variables are unneeded for their functions. Therefore, the unneeded
> return variables can be removed safely by returning their initial values.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> index e81dd34a3cac..dc93ddea8906 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> @@ -741,7 +741,6 @@ static int
> qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt) {
> struct qed_dcbx_mib_meta_data data;
> - int rc = 0;
>
> memset(&data, 0, sizeof(data));
> data.addr = p_hwfn->mcp_info->port_addr + offsetof(struct
> public_port, @@ -750,7 +749,7 @@ qed_dcbx_read_local_lldp_mib(struct
> qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
> data.size = sizeof(struct lldp_config_params_s);
> qed_memcpy_from(p_hwfn, p_ptt, data.lldp_local, data.addr,
> data.size);
>
> - return rc;
> + return 0;
> }
>
> static int
> @@ -810,7 +809,6 @@ static int
> qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt) {
> struct qed_dcbx_mib_meta_data data;
> - int rc = 0;
>
> memset(&data, 0, sizeof(data));
> data.addr = p_hwfn->mcp_info->port_addr + @@ -819,7 +817,7 @@
> qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt)
> data.size = sizeof(struct dcbx_local_params);
> qed_memcpy_from(p_hwfn, p_ptt, data.local_admin, data.addr,
> data.size);
>
> - return rc;
> + return 0;
> }
>
> static int qed_dcbx_read_mib(struct qed_hwfn *p_hwfn,
> --
> 2.32.0

Thanks!

Acked-by: Shai Malin <[email protected]>

2021-07-27 11:02:58

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: qed: remove unneeded return variables

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 25 Jul 2021 23:13:53 +0800 you wrote:
> Some return variables are never changed until function returned.
> These variables are unneeded for their functions. Therefore, the
> unneeded return variables can be removed safely by returning their
> initial values.
>
> Signed-off-by: Jason Wang <[email protected]>
>
> [...]

Here is the summary with links:
- net: qed: remove unneeded return variables
https://git.kernel.org/netdev/net-next/c/ef17e2ac2183

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html