2021-07-26 08:34:38

by Michał Mirosław

Subject: [PATCH] opp: remove WARN when no valid OPPs remain

This WARN can be triggered per-core and the stack trace is not useful.
Replace it with plain dev_err(). Fix a comment while at it.

Signed-off-by: Michał Mirosław <[email protected]>
---
drivers/opp/of.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index c582a9ca397b..01feeba78426 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
}
}

- /* There should be one of more OPP defined */
- if (WARN_ON(!count)) {
+ /* There should be one or more OPPs defined */
+ if (!count) {
+ dev_err(dev, "%s: no supported OPPs", __func__);
ret = -ENOENT;
goto remove_static_opp;
}
--
2.30.2

2021-07-26 09:04:29

by Viresh Kumar

Subject: Re: [PATCH] opp: remove WARN when no valid OPPs remain

On 26-07-21, 10:30, Michał Mirosław wrote:
> This WARN can be triggered per-core and the stack trace is not useful.
> Replace it with plain dev_err(). Fix a comment while at it.
>
> Signed-off-by: Michał Mirosław <[email protected]>
> ---
> drivers/opp/of.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index c582a9ca397b..01feeba78426 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
> }
> }
>
> - /* There should be one of more OPP defined */
> - if (WARN_ON(!count)) {
> + /* There should be one or more OPPs defined */
> + if (!count) {
> + dev_err(dev, "%s: no supported OPPs", __func__);
> ret = -ENOENT;
> goto remove_static_opp;
> }

Applied. Thanks.

--
viresh