2021-07-26 12:30:42

by Jason Wang

Subject: [PATCH] arm64: use __func__ to get function name in pr_err

Prefer using '"%s...", __func__' to get current function's name in
a debug message.

Signed-off-by: Jason Wang <[email protected]>
---
arch/arm64/lib/insn.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/lib/insn.c b/arch/arm64/lib/insn.c
index b506a4b1e38c..fccfe363e567 100644
--- a/arch/arm64/lib/insn.c
+++ b/arch/arm64/lib/insn.c
@@ -185,7 +185,7 @@ u64 aarch64_insn_decode_immediate(enum aarch64_insn_imm_type type, u32 insn)
break;
default:
if (aarch64_get_imm_shift_mask(type, &mask, &shift) < 0) {
- pr_err("aarch64_insn_decode_immediate: unknown immediate encoding %d\n",
+ pr_err("%s: unknown immediate encoding %d\n", __func__,
type);
return 0;
}
@@ -215,7 +215,7 @@ u32 __kprobes aarch64_insn_encode_immediate(enum aarch64_insn_imm_type type,
break;
default:
if (aarch64_get_imm_shift_mask(type, &mask, &shift) < 0) {
- pr_err("aarch64_insn_encode_immediate: unknown immediate encoding %d\n",
+ pr_err("%s: unknown immediate encoding %d\n", __func__,
type);
return AARCH64_BREAK_FAULT;
}
--
2.32.0

2021-07-30 12:26:53

by Will Deacon

Subject: Re: [PATCH] arm64: use __func__ to get function name in pr_err

On Mon, Jul 26, 2021 at 08:29:07PM +0800, Jason Wang wrote:
> Prefer using '"%s...", __func__' to get current function's name in
> a debug message.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> arch/arm64/lib/insn.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Will Deacon <[email protected]>

Will

2021-07-30 18:03:57

by Catalin Marinas

Subject: Re: [PATCH] arm64: use __func__ to get function name in pr_err

On Mon, 26 Jul 2021 20:29:07 +0800, Jason Wang wrote:
> Prefer using '"%s...", __func__' to get current function's name in
> a debug message.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: use __func__ to get function name in pr_err
https://git.kernel.org/arm64/c/2806556c5e1a

--
Catalin