Fix the clang build warning:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:1862:13: error: variable 'cur_data_offset' set but not used [-Werror,-Wunused-but-set-variable]
dma_addr_t cur_data_offset;
Signed-off-by: Bill Wendling <[email protected]>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 27943b0446c2..f255fd0b16db 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -1858,7 +1858,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp)
{
int i;
int first_queue_query_index, num_queues_req;
- dma_addr_t cur_data_offset;
struct stats_query_entry *cur_query_entry;
u8 stats_count = 0;
bool is_fcoe = false;
@@ -1879,10 +1878,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp)
BNX2X_NUM_ETH_QUEUES(bp), is_fcoe, first_queue_query_index,
first_queue_query_index + num_queues_req);
- cur_data_offset = bp->fw_stats_data_mapping +
- offsetof(struct bnx2x_fw_stats_data, queue_stats) +
- num_queues_req * sizeof(struct per_queue_stats);
-
cur_query_entry = &bp->fw_stats_req->
query[first_queue_query_index + num_queues_req];
@@ -1933,7 +1928,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp)
cur_query_entry->funcID,
j, cur_query_entry->index);
cur_query_entry++;
- cur_data_offset += sizeof(struct per_queue_stats);
stats_count++;
/* all stats are coalesced to the leading queue */
--
2.32.0.432.gabb21c7263-goog
On 7/26/2021 1:19 PM, 'Bill Wendling' via Clang Built Linux wrote:
> Fix the clang build warning:
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:1862:13: error: variable 'cur_data_offset' set but not used [-Werror,-Wunused-but-set-variable]
> dma_addr_t cur_data_offset;
>
> Signed-off-by: Bill Wendling <[email protected]>
It has been unused since the function's introduction in commit
67c431a5f2f3 ("bnx2x: Support statistics collection for VFs by the PF"),
perhaps a leftover remnant from a previous version?
Reviewed-by: Nathan Chancellor <[email protected]>
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index 27943b0446c2..f255fd0b16db 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -1858,7 +1858,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp)
> {
> int i;
> int first_queue_query_index, num_queues_req;
> - dma_addr_t cur_data_offset;
> struct stats_query_entry *cur_query_entry;
> u8 stats_count = 0;
> bool is_fcoe = false;
> @@ -1879,10 +1878,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp)
> BNX2X_NUM_ETH_QUEUES(bp), is_fcoe, first_queue_query_index,
> first_queue_query_index + num_queues_req);
>
> - cur_data_offset = bp->fw_stats_data_mapping +
> - offsetof(struct bnx2x_fw_stats_data, queue_stats) +
> - num_queues_req * sizeof(struct per_queue_stats);
> -
> cur_query_entry = &bp->fw_stats_req->
> query[first_queue_query_index + num_queues_req];
>
> @@ -1933,7 +1928,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp)
> cur_query_entry->funcID,
> j, cur_query_entry->index);
> cur_query_entry++;
> - cur_data_offset += sizeof(struct per_queue_stats);
> stats_count++;
>
> /* all stats are coalesced to the leading queue */
>
> -----Original Message-----
> From: Bill Wendling <[email protected]>
> Sent: Tuesday, July 27, 2021 1:49 AM
> To: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Nathan Chancellor
> <[email protected]>; Nick Desaulniers <[email protected]>; Ariel Elior
> <[email protected]>; Sudarsana Reddy Kalluru <[email protected]>; GR-
> everest-linux-l2 <[email protected]>; David S . Miller
> <[email protected]>; Nilesh Javali <[email protected]>; GR-QLogic-
> Storage-Upstream <[email protected]>; James E . J .
> Bottomley <[email protected]>; Martin K . Petersen
> <[email protected]>
> Cc: Bill Wendling <[email protected]>
> Subject: [EXT] [PATCH v2 2/3] bnx2x: remove unused variable 'cur_data_offset'
>
> Fix the clang build warning:
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:1862:13: error: variable
> 'cur_data_offset' set but not used [-Werror,-Wunused-but-set-variable]
> dma_addr_t cur_data_offset;
>
> Signed-off-by: Bill Wendling <[email protected]>
> ---
Acked-by: Prabhakar Kushwaha <[email protected]>