2021-07-25 22:17:24

by Artjom Vejsel

[permalink] [raw]
Subject: [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel

Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel.

Signed-off-by: Artjom Vejsel <[email protected]>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 3624363938dd..e7f3db118c5d 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -244,6 +244,8 @@ properties:
- powertip,ph800480t013-idf02
# QiaoDian XianShi Corporation 4"3 TFT LCD panel
- qiaodian,qd43003c0-40
+ # Shenzhen QiShenglong Industrialist Co., Ltd. Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel
+ - qishenglong,gopher2b-lcd-panel
# Rocktech Displays Ltd. RK101II01D-CT 10.1" TFT 1280x800
- rocktech,rk101ii01d-ct
# Rocktech Display Ltd. RK070ER9427 800(RGB)x480 TFT LCD panel
--
2.32.0


2021-07-25 23:11:10

by Paul Cercueil

[permalink] [raw]
Subject: Re: [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel

Hi Artjom,

Le lun., juil. 26 2021 at 01:15:26 +0300, Artjom Vejsel
<[email protected]> a ?crit :
> Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD
> panel.
>
> Signed-off-by: Artjom Vejsel <[email protected]>

Reviewed-by: Paul Cercueil <[email protected]>

Cheers,
-Paul

> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2
> ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3624363938dd..e7f3db118c5d 100644
> ---
> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++
> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -244,6 +244,8 @@ properties:
> - powertip,ph800480t013-idf02
> # QiaoDian XianShi Corporation 4"3 TFT LCD panel
> - qiaodian,qd43003c0-40
> + # Shenzhen QiShenglong Industrialist Co., Ltd. Gopher 2b
> 4.3" 480(RGB)x272 TFT LCD panel
> + - qishenglong,gopher2b-lcd-panel
> # Rocktech Displays Ltd. RK101II01D-CT 10.1" TFT 1280x800
> - rocktech,rk101ii01d-ct
> # Rocktech Display Ltd. RK070ER9427 800(RGB)x480 TFT LCD
> panel
> --
> 2.32.0
>


2021-07-26 22:55:26

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel

On Mon, Jul 26, 2021 at 01:15:26AM +0300, Artjom Vejsel wrote:
> Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel.
>
> Signed-off-by: Artjom Vejsel <[email protected]>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3624363938dd..e7f3db118c5d 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -244,6 +244,8 @@ properties:
> - powertip,ph800480t013-idf02
> # QiaoDian XianShi Corporation 4"3 TFT LCD panel
> - qiaodian,qd43003c0-40
> + # Shenzhen QiShenglong Industrialist Co., Ltd. Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel
> + - qishenglong,gopher2b-lcd-panel

Does 'gopher2b' refer to anything besides this panel? If not, then
'-lcd-panel' is redundant. Otherwise, '-panel' is redundant. Every LCD
is a panel.

> # Rocktech Displays Ltd. RK101II01D-CT 10.1" TFT 1280x800
> - rocktech,rk101ii01d-ct
> # Rocktech Display Ltd. RK070ER9427 800(RGB)x480 TFT LCD panel
> --
> 2.32.0
>
>