2021-07-27 02:06:18

by kernel test robot

[permalink] [raw]
Subject: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git generic_block_fiemap_removal
head: 8f04e4d9e612244a7fea6e3db4c5f117784212e3
commit: 9432c8ae9f99993c886a7a5b4b99b8e9af491183 [3/4] hpfs: use iomap_fiemap to implement ->fiemap
config: riscv-randconfig-r035-20210726 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/commit/?id=9432c8ae9f99993c886a7a5b4b99b8e9af491183
git remote add ext3 https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git
git fetch --no-tags ext3 generic_block_fiemap_removal
git checkout 9432c8ae9f99993c886a7a5b4b99b8e9af491183
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

riscv64-linux-ld: fs/ext2/inode.o: in function `.L468':
inode.c:(.text+0x2624): undefined reference to `iomap_fiemap'
riscv64-linux-ld: fs/hpfs/file.o: in function `.L0 ':
>> file.c:(.text+0x2a4): undefined reference to `iomap_fiemap'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (1.56 kB)
.config.gz (33.46 kB)
Download all attachments

2021-07-27 07:03:48

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'

Oops, hpfs now needs to select FS_IOMAP:

diff --git a/fs/hpfs/Kconfig b/fs/hpfs/Kconfig
index 2b36dc6f0a10..ec975f466877 100644
--- a/fs/hpfs/Kconfig
+++ b/fs/hpfs/Kconfig
@@ -2,6 +2,7 @@
config HPFS_FS
tristate "OS/2 HPFS file system support"
depends on BLOCK
+ select FS_IOMAP
help
OS/2 is IBM's operating system for PC's, the same as Warp, and HPFS
is the file system used for organizing files on OS/2 hard disk

2021-07-27 08:59:38

by Jan Kara

[permalink] [raw]
Subject: Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'

On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> Oops, hpfs now needs to select FS_IOMAP:

And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...

Honza

> diff --git a/fs/hpfs/Kconfig b/fs/hpfs/Kconfig
> index 2b36dc6f0a10..ec975f466877 100644
> --- a/fs/hpfs/Kconfig
> +++ b/fs/hpfs/Kconfig
> @@ -2,6 +2,7 @@
> config HPFS_FS
> tristate "OS/2 HPFS file system support"
> depends on BLOCK
> + select FS_IOMAP
> help
> OS/2 is IBM's operating system for PC's, the same as Warp, and HPFS
> is the file system used for organizing files on OS/2 hard disk
--
Jan Kara <[email protected]>
SUSE Labs, CR

2021-07-27 09:01:27

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'

On Tue, Jul 27, 2021 at 10:55:51AM +0200, Jan Kara wrote:
> On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> > Oops, hpfs now needs to select FS_IOMAP:
>
> And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
> which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...

Indeed.

2021-07-27 09:09:39

by Jan Kara

[permalink] [raw]
Subject: Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'

On Tue 27-07-21 10:57:42, Christoph Hellwig wrote:
> On Tue, Jul 27, 2021 at 10:55:51AM +0200, Jan Kara wrote:
> > On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> > > Oops, hpfs now needs to select FS_IOMAP:
> >
> > And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
> > which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...
>
> Indeed.

I've ammended the two commits and pushed the result out.
Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR

2021-07-27 18:33:26

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'

On Tue, 27 Jul 2021 at 14:37, Jan Kara <[email protected]> wrote:
>
> On Tue 27-07-21 10:57:42, Christoph Hellwig wrote:
> > On Tue, Jul 27, 2021 at 10:55:51AM +0200, Jan Kara wrote:
> > > On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> > > > Oops, hpfs now needs to select FS_IOMAP:
> > >
> > > And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
> > > which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...
> >
> > Indeed.
>
> I've ammended the two commits and pushed the result out.

Thank you !

FYI,
The reported build failures noticed today's linux next 20210727 tag on
- arc (defconfig) with gcc-9
- sparc (defconfig) with gcc-10

arc-elf32-ld: fs/ext2/inode.o: in function `ext2_fiemap':
inode.c:(.text+0x1c24): undefined reference to `iomap_fiemap'
arc-elf32-ld: inode.c:(.text+0x1c24): undefined reference to `iomap_fiemap'

- Naresh