2021-08-10 16:47:49

by Tom Rix

Subject: [PATCH] fpga: machxo2-spi: return an error on failure

From: Tom Rix <[email protected]>

Reported problem

drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
warn: missing error code 'ret'

drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
warn: missing error code 'ret'

Earlier successes leave 'ret' in a non error state, so these errors are
not reported. So set ret to -EINVAL before going to the error handler.

Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Tom Rix <[email protected]>
---
drivers/fpga/machxo2-spi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c
index 1afb41aa20d71..b4a530a31302f 100644
--- a/drivers/fpga/machxo2-spi.c
+++ b/drivers/fpga/machxo2-spi.c
@@ -225,8 +225,10 @@ static int machxo2_write_init(struct fpga_manager *mgr,
goto fail;

get_status(spi, &status);
- if (test_bit(FAIL, &status))
+ if (test_bit(FAIL, &status)) {
+ ret = -EINVAL;
goto fail;
+ }
dump_status_reg(&status);

spi_message_init(&msg);
@@ -313,6 +315,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
dump_status_reg(&status);
if (!test_bit(DONE, &status)) {
machxo2_cleanup(mgr);
+ ret = -EINVAL;
goto fail;
}

--
2.26.3

2021-08-10 17:08:29

by Greg Kroah-Hartman

Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure

On Tue, Aug 10, 2021 at 09:40:36AM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> Reported problem
>
> drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> warn: missing error code 'ret'
>
> drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> warn: missing error code 'ret'

What reported this? What does it mean? Where was it reported?

please be specific...

thanks,

greg k-h

2021-08-10 18:53:39

by Dan Carpenter

Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure

On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> On Tue, Aug 10, 2021 at 09:40:36AM -0700, [email protected] wrote:
> > From: Tom Rix <[email protected]>
> >
> > Reported problem
> >
> > drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > warn: missing error code 'ret'
> >
> > drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > warn: missing error code 'ret'
>
> What reported this? What does it mean? Where was it reported?

These are Smatch errors, but my bug reports don't mention Smatch so
that's on me. I've fixed my report templated to mention Smatch now.

regards,
dan carepenter

2021-08-11 11:31:10

by Moritz Fischer

Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure

On Tue, Aug 10, 2021 at 09:51:16PM +0300, Dan Carpenter wrote:
> On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> > On Tue, Aug 10, 2021 at 09:40:36AM -0700, [email protected] wrote:
> > > From: Tom Rix <[email protected]>
> > >
> > > Reported problem
> > >
> > > drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > > warn: missing error code 'ret'
> > >
> > > drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > > warn: missing error code 'ret'
> >
> > What reported this? What does it mean? Where was it reported?
>
> These are Smatch errors, but my bug reports don't mention Smatch so
> that's on me. I've fixed my report templated to mention Smatch now.
>
> regards,
> dan carepenter
>
>
Applied with slightly reworded commit-message to 'fixes' branch.

Thanks,
Moritz