2021-08-12 09:36:08

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
FSL_FMAN_MAC never existed in the kernel tree.

Hence, ./scripts/checkkconfigsymbols.py warns:

FSL_FMAN_MAC
Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig

Remove this dead select in menuconfig FSL_DPAA_ETH.

Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig b/drivers/net/ethernet/freescale/dpaa/Kconfig
index 626ec58a0afc..0e1439fd00bd 100644
--- a/drivers/net/ethernet/freescale/dpaa/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
@@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
depends on FSL_DPAA && FSL_FMAN
select PHYLIB
select FIXED_PHY
- select FSL_FMAN_MAC
help
Data Path Acceleration Architecture Ethernet driver,
supporting the Freescale QorIQ chips.
--
2.17.1


2021-08-12 09:43:17

by Madalin Bucur (OSS)

[permalink] [raw]
Subject: RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

> -----Original Message-----
> From: Lukas Bulwahn <[email protected]>
> Sent: 12 August 2021 11:38
> To: David S . Miller <[email protected]>; Jakub Kicinski
> <[email protected]>; [email protected]
> Cc: Madalin Bucur <[email protected]>; Randy Dunlap
> <[email protected]>; [email protected]; linux-
> [email protected]; Lukas Bulwahn <[email protected]>
> Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
> FSL_DPAA_ETH
>
> The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
> FSL_FMAN_MAC never existed in the kernel tree.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> FSL_FMAN_MAC
> Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
>
> Remove this dead select in menuconfig FSL_DPAA_ETH.
>
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig
> b/drivers/net/ethernet/freescale/dpaa/Kconfig
> index 626ec58a0afc..0e1439fd00bd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/Kconfig
> +++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
> @@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
> depends on FSL_DPAA && FSL_FMAN
> select PHYLIB
> select FIXED_PHY
> - select FSL_FMAN_MAC
> help
> Data Path Acceleration Architecture Ethernet driver,
> supporting the Freescale QorIQ chips.
> --
> 2.17.1

Acked-by: Madalin Bucur <[email protected]>