2021-08-09 10:05:49

by Clark Wang

Subject: [PATCH V4 0/8] i3c: master: svc: some bug fixes and add runtime pm support

Hi,

V4 changes:
- New patches:
- i3c: master: svc: separate err, fifo and disable interrupt of reset function
- i3c: master: svc: add the missing module device table
- i3c: master: svc: enable the interrupt in the enable ibi function
- i3c: master: svc: add support for slave to stop returning data
- Only use COMPLETE flag in the read function.
- Add a reset before each transfer.
- i3c: master: svc: add runtime pm support
- error path emit_stop only used in svc_i3c_master_do_daa() for one time, so
remove it. Or it needs another goto command at the end of the function to
skip it and to go to rpm_out.

V3 changes:
- i3c: master: svc: add runtime pm support:
- restore the error path of probe function
- enable runtime pm just before i3c module reset

V2 changes:
- align the parameters of the function in the second patch
- add a new patch to support runtime PM.

Clark Wang (8):
i3c: master: svc: move module reset behind clk enable
i3c: master: svc: fix atomic issue
i3c: master: svc: separate err, fifo and disable interrupt of reset
function
i3c: master: svc: add support for slave to stop returning data
i3c: master: svc: set ODSTOP to let I2C device see the STOP signal
i3c: master: svc: add runtime pm support
i3c: master: svc: add the missing module device table
i3c: master: svc: enable the interrupt in the enable ibi function

drivers/i3c/master/svc-i3c-master.c | 307 +++++++++++++++++++++-------
1 file changed, 231 insertions(+), 76 deletions(-)

--
2.25.1

2021-08-09 10:05:51

by Clark Wang

Subject: [PATCH V4 7/8] i3c: master: svc: add the missing module device table

The missing MODULE_DEVICE_TABLE() will cause the svc-i3c-master cannot
be auto probed when it is built in moudle.
So add it.

Signed-off-by: Clark Wang <[email protected]>
Reviewed-by: Jun Li <[email protected]>
---
V4: New patch in this patchset
---
drivers/i3c/master/svc-i3c-master.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 5939e0936697..77f67d407acd 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1612,6 +1612,7 @@ static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
{ .compatible = "silvaco,i3c-master" },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);

static struct platform_driver svc_i3c_master = {
.probe = svc_i3c_master_probe,
--
2.25.1

2021-08-16 07:01:12

by Miquel Raynal

Subject: Re: [PATCH V4 7/8] i3c: master: svc: add the missing module device table

Hi Clark,

Clark Wang <[email protected]> wrote on Mon, 9 Aug 2021 14:36:44
+0800:

> The missing MODULE_DEVICE_TABLE() will cause the svc-i3c-master cannot
> be auto probed when it is built in moudle.
> So add it.
>
> Signed-off-by: Clark Wang <[email protected]>
> Reviewed-by: Jun Li <[email protected]>

Reviewed-by: Miquel Raynal <[email protected]>

> ---
> V4: New patch in this patchset
> ---
> drivers/i3c/master/svc-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 5939e0936697..77f67d407acd 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1612,6 +1612,7 @@ static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
> { .compatible = "silvaco,i3c-master" },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
>
> static struct platform_driver svc_i3c_master = {
> .probe = svc_i3c_master_probe,

Thanks,
Miquèl