2021-08-17 21:51:48

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the i2c tree

Hi all,

In commit

fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check")

Fixes tag

Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")

has these problem(s):

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

Or maybe you meant:

Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-08-18 17:31:40

by Sergey Shtylyov

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the i2c tree

On 8/18/21 12:49 AM, Stephen Rothwell wrote:

[...]
> In commit
>
> fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check")
>
> Fixes tag
>
> Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
> So:
>
> Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

Sorry for this copypaste blunder. :-/

> Or maybe you meant:
>
> Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")

Yes, this one looks more correct.

Wolfram, what should we do now?

MBR, Sergei

2021-08-19 17:25:10

by Wolfram Sang

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the i2c tree


> > Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
>
> Yes, this one looks more correct.
>
> Wolfram, what should we do now?

I'll fix it locally. Thanks, Stephen for the report and fix!

Attachments:
(No filename) (228.00 B)
 signature.asc (849.00 B)
 Download all attachments