2021-09-03 21:32:25

by Kari Argillander

[permalink] [raw]
Subject: [PATCH] ACPI: scan: Remove unneeded header linux/nls.h

Code that use linux/nls.h was moved to device_sysfs.c by commit
c2efefb33abf ("ACPI / scan: Move sysfs-related device code to a separate file")

Remove this include so that complier has easier times and it would be
easier to grep where nls code is used.

Signed-off-by: Kari Argillander <[email protected]>
---
drivers/acpi/scan.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index b24513ec3fae..5b54c80b9d32 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -16,7 +16,6 @@
#include <linux/signal.h>
#include <linux/kthread.h>
#include <linux/dmi.h>
-#include <linux/nls.h>
#include <linux/dma-map-ops.h>
#include <linux/platform_data/x86/apple.h>
#include <linux/pgtable.h>
--
2.30.2


2021-09-07 19:16:54

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: scan: Remove unneeded header linux/nls.h

On Fri, Sep 3, 2021 at 11:07 PM Kari Argillander
<[email protected]> wrote:
>
> Code that use linux/nls.h was moved to device_sysfs.c by commit
> c2efefb33abf ("ACPI / scan: Move sysfs-related device code to a separate file")
>
> Remove this include so that complier has easier times and it would be
> easier to grep where nls code is used.
>
> Signed-off-by: Kari Argillander <[email protected]>
> ---
> drivers/acpi/scan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index b24513ec3fae..5b54c80b9d32 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -16,7 +16,6 @@
> #include <linux/signal.h>
> #include <linux/kthread.h>
> #include <linux/dmi.h>
> -#include <linux/nls.h>
> #include <linux/dma-map-ops.h>
> #include <linux/platform_data/x86/apple.h>
> #include <linux/pgtable.h>
> --

Applied as 5.15-rc material, thanks!