2021-09-19 12:25:09

by Daniel Palmer

Subject: [PATCH] iio: accel: mma7660: Mark acpi match table as maybe unused

When building kernels without ACPI support the table is declared
but is not used because ACPI_PTR() turns it into a NULL.

Add the __maybe_unused attribute to stop the compiler whining.

Signed-off-by: Daniel Palmer <[email protected]>
---
drivers/iio/accel/mma7660.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/mma7660.c b/drivers/iio/accel/mma7660.c
index 47f5cd66e996..cd6cdf2c51b0 100644
--- a/drivers/iio/accel/mma7660.c
+++ b/drivers/iio/accel/mma7660.c
@@ -254,7 +254,7 @@ static const struct of_device_id mma7660_of_match[] = {
};
MODULE_DEVICE_TABLE(of, mma7660_of_match);

-static const struct acpi_device_id mma7660_acpi_id[] = {
+static const struct acpi_device_id __maybe_unused mma7660_acpi_id[] = {
{"MMA7660", 0},
{}
};
--
2.33.0

2021-09-19 18:09:34

by Jonathan Cameron

Subject: Re: [PATCH] iio: accel: mma7660: Mark acpi match table as maybe unused

On Sun, 19 Sep 2021 16:26:16 +0900
Daniel Palmer <[email protected]> wrote:

> When building kernels without ACPI support the table is declared
> but is not used because ACPI_PTR() turns it into a NULL.
>
> Add the __maybe_unused attribute to stop the compiler whining.
>
> Signed-off-by: Daniel Palmer <[email protected]>
Applied to the togreg branch of iio.git which is initially pushed out as testing
to let 0-day poke at it and see if we missed anything.

Thanks,

Jonathan

> ---
> drivers/iio/accel/mma7660.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma7660.c b/drivers/iio/accel/mma7660.c
> index 47f5cd66e996..cd6cdf2c51b0 100644
> --- a/drivers/iio/accel/mma7660.c
> +++ b/drivers/iio/accel/mma7660.c
> @@ -254,7 +254,7 @@ static const struct of_device_id mma7660_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, mma7660_of_match);
>
> -static const struct acpi_device_id mma7660_acpi_id[] = {
> +static const struct acpi_device_id __maybe_unused mma7660_acpi_id[] = {
> {"MMA7660", 0},
> {}
> };