2021-10-12 11:30:47

by Alvin Šipraga

Subject: [PATCH net] net: dsa: fix spurious error message when unoffloaded port leaves bridge

From: Alvin Šipraga <[email protected]>

Flip the sign of a return value check, thereby suppressing the following
spurious error:

port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP

... which is emitted when removing an unoffloaded DSA switch port from a
bridge.

Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
Signed-off-by: Alvin Šipraga <[email protected]>
---
net/dsa/switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index 1c797ec8e2c2..6466d0539af9 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -168,7 +168,7 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds,
if (extack._msg)
dev_err(ds->dev, "port %d: %s\n", info->port,
extack._msg);
- if (err && err != EOPNOTSUPP)
+ if (err && err != -EOPNOTSUPP)
return err;
}

--
2.32.0

2021-10-12 11:38:40

by Vladimir Oltean

Subject: Re: [PATCH net] net: dsa: fix spurious error message when unoffloaded port leaves bridge

On Tue, Oct 12, 2021 at 01:27:31PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <[email protected]>
>
> Flip the sign of a return value check, thereby suppressing the following
> spurious error:
>
> port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP
>
> ... which is emitted when removing an unoffloaded DSA switch port from a
> bridge.
>
> Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
> Signed-off-by: Alvin Šipraga <[email protected]>
> ---
> net/dsa/switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/switch.c b/net/dsa/switch.c
> index 1c797ec8e2c2..6466d0539af9 100644
> --- a/net/dsa/switch.c
> +++ b/net/dsa/switch.c
> @@ -168,7 +168,7 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds,
> if (extack._msg)
> dev_err(ds->dev, "port %d: %s\n", info->port,
> extack._msg);
> - if (err && err != EOPNOTSUPP)
> + if (err && err != -EOPNOTSUPP)
> return err;
> }
>
> --
> 2.32.0
>

Ouch, good catch.

Reviewed-by: Vladimir Oltean <[email protected]>

2021-10-12 16:22:33

by Florian Fainelli

Subject: Re: [PATCH net] net: dsa: fix spurious error message when unoffloaded port leaves bridge

On 10/12/21 4:27 AM, Alvin Šipraga wrote:
> From: Alvin Šipraga <[email protected]>
>
> Flip the sign of a return value check, thereby suppressing the following
> spurious error:
>
> port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP
>
> ... which is emitted when removing an unoffloaded DSA switch port from a
> bridge.
>
> Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
> Signed-off-by: Alvin Šipraga <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2021-10-12 23:33:12

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: dsa: fix spurious error message when unoffloaded port leaves bridge

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 12 Oct 2021 13:27:31 +0200 you wrote:
> From: Alvin Šipraga <[email protected]>
>
> Flip the sign of a return value check, thereby suppressing the following
> spurious error:
>
> port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP
>
> [...]

Here is the summary with links:
- [net] net: dsa: fix spurious error message when unoffloaded port leaves bridge
https://git.kernel.org/netdev/net/c/43a4b4dbd48c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html