2021-10-18 10:04:58

by Martin Kepplinger

Subject: [PATCH] media: hi846: depend on OF

Since other device enumerate mechanisms are currently not implemented,
make the hi846 sensor driver depend on CONFIG_OF.

Signed-off-by: Martin Kepplinger <[email protected]>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 0e56489c97fb..53268f1f761f 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -746,6 +746,7 @@ config VIDEO_HI556
config VIDEO_HI846
tristate "Hynix Hi-846 sensor support"
depends on I2C && VIDEO_V4L2
+ depends on OF
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.30.2

2021-10-18 13:47:25

by Martin Kepplinger

Subject: [PATCH v2] media: hi846: depend on OF

Since other device enumerate mechanisms are currently not implemented,
make the hi846 sensor driver depend on CONFIG_OF.

Signed-off-by: Martin Kepplinger <[email protected]>
Reported-by: kernel test robot <[email protected]>
---

revision history
----------------
v2:
* added the reported-by tag

v1:
https://lore.kernel.org/linux-media/[email protected]/



drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 0e56489c97fb..53268f1f761f 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -746,6 +746,7 @@ config VIDEO_HI556
config VIDEO_HI846
tristate "Hynix Hi-846 sensor support"
depends on I2C && VIDEO_V4L2
+ depends on OF
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.30.2

2021-10-19 12:29:17

by Sakari Ailus

Subject: Re: [PATCH v2] media: hi846: depend on OF

Hi Martin,

On Mon, Oct 18, 2021 at 03:42:46PM +0200, Martin Kepplinger wrote:
> Since other device enumerate mechanisms are currently not implemented,
> make the hi846 sensor driver depend on CONFIG_OF.

As far as I understand, this should work on ACPI based systems with just
of_match_ptr() macro removed.

In any case, linux/of_graph.h header should be replaced with
linux/property.h.

How about that instead?

--
Kind regards,

Sakari Ailus