2021-11-02 19:12:18

by Nghia Le

Subject: [PATCH] io_uring: remove redundant assignment to ret in io_register_iowq_max_workers()

After the assignment, only exit path with label 'err' uses ret as
return value. However,before exiting through this path with label 'err',
ret is assigned with the return value of io_wq_max_workers(). Hence, the
initial assignment is redundant and can be removed.

Signed-off-by: Nghia Le <[email protected]>
---
fs/io_uring.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index acc05ff3aa19..d18f1f46ca83 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -10800,7 +10800,6 @@ static __cold int io_register_iowq_max_workers(struct io_ring_ctx *ctx,
memcpy(ctx->iowq_limits, new_count, sizeof(new_count));
ctx->iowq_limits_set = true;

- ret = -EINVAL;
if (tctx && tctx->io_wq) {
ret = io_wq_max_workers(tctx->io_wq, new_count);
if (ret)
--
2.25.1

2021-11-02 20:34:07

by Jens Axboe

Subject: Re: [PATCH] io_uring: remove redundant assignment to ret in io_register_iowq_max_workers()

On Wed, 3 Nov 2021 02:05:21 +0700, Nghia Le wrote:
> After the assignment, only exit path with label 'err' uses ret as
> return value. However,before exiting through this path with label 'err',
> ret is assigned with the return value of io_wq_max_workers(). Hence, the
> initial assignment is redundant and can be removed.
>
>

Applied, thanks!

[1/1] io_uring: remove redundant assignment to ret in io_register_iowq_max_workers()
commit: 83956c86fffe0465408c7d62e925d88748075e00

Best regards,
--
Jens Axboe