2021-11-13 03:12:06

by Jason Wang

Subject: [PATCH] ARM: s3c: Fix typo in one comment

The double `would' in the comment might be repeated. Remove one of them
from the comment.

Signed-off-by: Jason Wang <[email protected]>
---
arch/arm/mach-s3c/mach-gta02.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
index 418939ce0fc3..174b2e55ea16 100644
--- a/arch/arm/mach-s3c/mach-gta02.c
+++ b/arch/arm/mach-s3c/mach-gta02.c
@@ -393,9 +393,9 @@ static struct s3c2410_nand_set __initdata gta02_nand_sets[] = {
[0] = {
/*
* This name is also hard-coded in the boot loaders, so
- * changing it would would require all users to upgrade
- * their boot loaders, some of which are stored in a NOR
- * that is considered to be immutable.
+ * changing it would require all users to upgrade their
+ * boot loaders, some of which are stored in a NOR that
+ * is considered to be immutable.
*/
.name = "neo1973-nand",
.nr_chips = 1,
--
2.33.0

2021-11-15 08:48:13

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: s3c: Fix typo in one comment

On 13/11/2021 04:11, Jason Wang wrote:
> The double `would' in the comment might be repeated. Remove one of them
> from the comment.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> arch/arm/mach-s3c/mach-gta02.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
> index 418939ce0fc3..174b2e55ea16 100644
> --- a/arch/arm/mach-s3c/mach-gta02.c
> +++ b/arch/arm/mach-s3c/mach-gta02.c
> @@ -393,9 +393,9 @@ static struct s3c2410_nand_set __initdata gta02_nand_sets[] = {
> [0] = {
> /*
> * This name is also hard-coded in the boot loaders, so
> - * changing it would would require all users to upgrade
> - * their boot loaders, some of which are stored in a NOR
> - * that is considered to be immutable.
> + * changing it would require all users to upgrade their
> + * boot loaders, some of which are stored in a NOR that
> + * is considered to be immutable.
> */

This is a legacy platform, bigger set of cleanups are accepted but a
patch which changes only one typo, is not. Especially that you change
here three lines for this simple one typo.

Please send a bigger cleanup for all of such issues or skip it.

Best regards,
Krzysztof