2021-11-13 05:59:27

by Jason Wang

Subject: [PATCH] soc: fsl: qe: Fix typo in a comment

The double `is' in a comment is repeated, thus one of them
should be removed.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/soc/fsl/qe/qe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 4d38c80f8be8..b3c226eb5292 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -147,7 +147,7 @@ EXPORT_SYMBOL(qe_issue_cmd);
* memory mapped space.
* The BRG clock is the QE clock divided by 2.
* It was set up long ago during the initial boot phase and is
- * is given to us.
+ * given to us.
* Baud rate clocks are zero-based in the driver code (as that maps
* to port numbers). Documentation uses 1-based numbering.
*/
@@ -421,7 +421,7 @@ static void qe_upload_microcode(const void *base,

for (i = 0; i < be32_to_cpu(ucode->count); i++)
iowrite32be(be32_to_cpu(code[i]), &qe_immr->iram.idata);
-
+
/* Set I-RAM Ready Register */
iowrite32be(QE_IRAM_READY, &qe_immr->iram.iready);
}
--
2.33.0

2021-11-15 08:08:12

by Christophe Leroy

Subject: Re: [PATCH] soc: fsl: qe: Fix typo in a comment

Le 13/11/2021 à 06:59, Jason Wang a écrit :
> The double `is' in a comment is repeated, thus one of them
> should be removed.

You are also clean blanks it seems, so say it or don't do it.

>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/soc/fsl/qe/qe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
> index 4d38c80f8be8..b3c226eb5292 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -147,7 +147,7 @@ EXPORT_SYMBOL(qe_issue_cmd);
> * memory mapped space.
> * The BRG clock is the QE clock divided by 2.
> * It was set up long ago during the initial boot phase and is
> - * is given to us.
> + * given to us.
> * Baud rate clocks are zero-based in the driver code (as that maps
> * to port numbers). Documentation uses 1-based numbering.
> */
> @@ -421,7 +421,7 @@ static void qe_upload_microcode(const void *base,
>
> for (i = 0; i < be32_to_cpu(ucode->count); i++)
> iowrite32be(be32_to_cpu(code[i]), &qe_immr->iram.idata);
> -
> +

This change is not linked to the double "is".

> /* Set I-RAM Ready Register */
> iowrite32be(QE_IRAM_READY, &qe_immr->iram.iready);
> }
>