2021-11-14 06:03:00

by Jason Wang

Subject: [PATCH] igb: remove never changed variable `ret_val'

The variable used for return status in `igb_write_xmdio_reg' function
is never changed and this function is just need return 0. Thus, the
`ret_val' can be removed and return 0 at the end of the
`igb_write_xmdio_reg' function.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/net/ethernet/intel/igb/e1000_i210.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/e1000_i210.c b/drivers/net/ethernet/intel/igb/e1000_i210.c
index 9265901455cd..b9b9d35494d2 100644
--- a/drivers/net/ethernet/intel/igb/e1000_i210.c
+++ b/drivers/net/ethernet/intel/igb/e1000_i210.c
@@ -792,7 +792,6 @@ s32 igb_write_xmdio_reg(struct e1000_hw *hw, u16 addr, u8 dev_addr, u16 data)
**/
s32 igb_init_nvm_params_i210(struct e1000_hw *hw)
{
- s32 ret_val = 0;
struct e1000_nvm_info *nvm = &hw->nvm;

nvm->ops.acquire = igb_acquire_nvm_i210;
@@ -813,7 +812,7 @@ s32 igb_init_nvm_params_i210(struct e1000_hw *hw)
nvm->ops.validate = NULL;
nvm->ops.update = NULL;
}
- return ret_val;
+ return 0;
}

/**
--
2.33.0

2021-11-24 13:04:07

by G, GurucharanX

Subject: RE: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret_val'

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Jason Wang
> Sent: Sunday, November 14, 2021 11:32 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; Jason Wang
> <[email protected]>; [email protected];
> [email protected]
> Subject: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret_val'
>
> The variable used for return status in `igb_write_xmdio_reg' function is never
> changed and this function is just need return 0. Thus, the `ret_val' can be
> removed and return 0 at the end of the `igb_write_xmdio_reg' function.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/net/ethernet/intel/igb/e1000_i210.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Tested-by: Gurucharan G <[email protected]> (A Contingent worker at Intel)