2021-11-24 05:22:50

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warnings after merge of the hwmon-staging tree

Hi all,

After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced these warnings:

Documentation/hwmon/asus_wmi_sensors.rst:33: WARNING: Unexpected indentation.
Documentation/hwmon/asus_wmi_sensors.rst:68: WARNING: Unexpected indentation.
Documentation/hwmon/asus_wmi_sensors.rst:76: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2021-11-24 06:44:52

by Denis Pauk

[permalink] [raw]
Subject: [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation.

Fixes: 9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")

Signed-off-by: Denis Pauk <[email protected]>
---
Documentation/hwmon/asus_wmi_sensors.rst | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/hwmon/asus_wmi_sensors.rst b/Documentation/hwmon/asus_wmi_sensors.rst
index 408fd3b4a0de..8f2096cf5183 100644
--- a/Documentation/hwmon/asus_wmi_sensors.rst
+++ b/Documentation/hwmon/asus_wmi_sensors.rst
@@ -29,7 +29,9 @@ ASUS mainboards publish hardware monitoring information via WMI interface.

ASUS WMI interface provides a methods to get list of sensors and values of
such, which is utilized by this driver to publish those sensor readings to the
-HWMON system. The driver is aware of and reads the following sensors:
+HWMON system.
+
+The driver is aware of and reads the following sensors:
* CPU Core Voltage,
* CPU SOC Voltage,
* DRAM Voltage,
@@ -64,7 +66,7 @@ HWMON system. The driver is aware of and reads the following sensors:
* CPU VRM Output Current.

Known Issues:
-* The WMI implementation in some of Asus' BIOSes is buggy. This can result in
+ * The WMI implementation in some of Asus' BIOSes is buggy. This can result in
fans stopping, fans getting stuck at max speed, or temperature readouts
getting stuck. This is not an issue with the driver, but the BIOS. The Prime
X470 Pro seems particularly bad for this. The more frequently the WMI
@@ -73,4 +75,4 @@ Known Issues:
sensors frequently, don't leave you computer unattended. Upgrading to new
BIOS version with method version greater than or equal to two should
rectify the issue.
-* A few boards report 12v voltages to be ~10v.
+ * A few boards report 12v voltages to be ~10v.

base-commit: 9d07e54a25b84099983f56e33e00f2914f06b53f
--
2.33.0


2021-11-24 14:42:21

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation.

On 11/23/21 10:43 PM, Denis Pauk wrote:
> Fixes: 9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")
>
> Signed-off-by: Denis Pauk <[email protected]>

Squashed into offending commit.

However, for the future,
1) Please always provide a full description of the problem
2) Never send a patch as reply to a previous patch, or as reply
to a bug report, unless you want it to get lost.

Where is that "send patch as reply" thing coming from ?
It seems to proliferate for some reason. Is someone promoting that ?

Thanks,
Guenter

> ---
> Documentation/hwmon/asus_wmi_sensors.rst | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/hwmon/asus_wmi_sensors.rst b/Documentation/hwmon/asus_wmi_sensors.rst
> index 408fd3b4a0de..8f2096cf5183 100644
> --- a/Documentation/hwmon/asus_wmi_sensors.rst
> +++ b/Documentation/hwmon/asus_wmi_sensors.rst
> @@ -29,7 +29,9 @@ ASUS mainboards publish hardware monitoring information via WMI interface.
>
> ASUS WMI interface provides a methods to get list of sensors and values of
> such, which is utilized by this driver to publish those sensor readings to the
> -HWMON system. The driver is aware of and reads the following sensors:
> +HWMON system.
> +
> +The driver is aware of and reads the following sensors:
> * CPU Core Voltage,
> * CPU SOC Voltage,
> * DRAM Voltage,
> @@ -64,7 +66,7 @@ HWMON system. The driver is aware of and reads the following sensors:
> * CPU VRM Output Current.
>
> Known Issues:
> -* The WMI implementation in some of Asus' BIOSes is buggy. This can result in
> + * The WMI implementation in some of Asus' BIOSes is buggy. This can result in
> fans stopping, fans getting stuck at max speed, or temperature readouts
> getting stuck. This is not an issue with the driver, but the BIOS. The Prime
> X470 Pro seems particularly bad for this. The more frequently the WMI
> @@ -73,4 +75,4 @@ Known Issues:
> sensors frequently, don't leave you computer unattended. Upgrading to new
> BIOS version with method version greater than or equal to two should
> rectify the issue.
> -* A few boards report 12v voltages to be ~10v.
> + * A few boards report 12v voltages to be ~10v.
>
> base-commit: 9d07e54a25b84099983f56e33e00f2914f06b53f
>