2021-11-24 14:08:09

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.4 000/100] 5.4.162-rc1 review

This is the start of the stable review cycle for the 5.4.162 release.
There are 100 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.162-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.4.162-rc1

Nadav Amit <[email protected]>
hugetlbfs: flush TLBs correctly after huge_pmd_unshare

Peter Zijlstra (Intel) <[email protected]>
tlb: mmu_gather: add tlb_flush_*_range APIs

Leon Romanovsky <[email protected]>
ice: Delete always true check of PF pointer

Uwe Kleine-König <[email protected]>
usb: max-3421: Use driver data instead of maintaining a list of bound devices

Takashi Iwai <[email protected]>
ASoC: DAPM: Cover regression by kctl change notification fix

Sven Eckelmann <[email protected]>
batman-adv: Don't always reallocate the fragmentation skb head

Sven Eckelmann <[email protected]>
batman-adv: Reserve needed_*room for fragments

Sven Eckelmann <[email protected]>
batman-adv: Consider fragmentation for needed_headroom

Greg Thelen <[email protected]>
perf/core: Avoid put_page() when GUP fails

Greg Kroah-Hartman <[email protected]>
Revert "net: mvpp2: disable force link UP during port init procedure"

hongao <[email protected]>
drm/amdgpu: fix set scaling mode Full/Full aspect/Center not works on vga and dvi connectors

Imre Deak <[email protected]>
drm/i915/dp: Ensure sink rate values are always valid

Jeremy Cline <[email protected]>
drm/nouveau: use drm_dev_unplug() during device removal

Johan Hovold <[email protected]>
drm/udl: fix control-message timeout

Nguyen Dinh Phi <[email protected]>
cfg80211: call cfg80211_stop_ap when switch from P2P_GO type

Sven Schnelle <[email protected]>
parisc/sticon: fix reverse colors

Nikolay Borisov <[email protected]>
btrfs: fix memory ordering between normal and ordered work functions

Jan Kara <[email protected]>
udf: Fix crash after seekdir

Baoquan He <[email protected]>
s390/kexec: fix memory leak of ipl report buffer

Sean Christopherson <[email protected]>
x86/hyperv: Fix NULL deref in set_hv_tscchange_cb() if Hyper-V setup fails

Rustam Kovhaev <[email protected]>
mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag

Alexander Mikhalitsyn <[email protected]>
ipc: WARN if trying to remove ipc object which is absent

Nathan Chancellor <[email protected]>
hexagon: export raw I/O routines for modules

Nicolas Dichtel <[email protected]>
tun: fix bonding active backup with arp monitoring

Nick Desaulniers <[email protected]>
arm64: vdso32: suppress error message for 'make mrproper'

Heiko Carstens <[email protected]>
s390/kexec: fix return code handling

Alexander Antonov <[email protected]>
perf/x86/intel/uncore: Fix IIO event constraints for Skylake Server

Alexander Antonov <[email protected]>
perf/x86/intel/uncore: Fix filter_tid mask for CHA events on Skylake Server

Michael Ellerman <[email protected]>
KVM: PPC: Book3S HV: Use GLOBAL_TOC for kvmppc_h_set_dabr/xdabr()

Sohaib Mohamed <[email protected]>
perf bench: Fix two memory leaks detected with ASan

Lin Ma <[email protected]>
NFC: reorder the logic in nfc_{un,}register_device

Hans Verkuil <[email protected]>
drm/nouveau: hdmigv100.c: fix corrupted HDMI Vendor InfoFrame

Lin Ma <[email protected]>
NFC: reorganize the functions in nci_request

Grzegorz Szczurek <[email protected]>
i40e: Fix display error code in dmesg

Jedrzej Jagielski <[email protected]>
i40e: Fix creation of first queue by omitting it if is not power of two

Eryk Rybak <[email protected]>
i40e: Fix ping is lost after configuring ADq on VF

Eryk Rybak <[email protected]>
i40e: Fix changing previously set num_queue_pairs for PFs

Michal Maloszewski <[email protected]>
i40e: Fix NULL ptr dereference on VSI filter sync

Eryk Rybak <[email protected]>
i40e: Fix correct max_pkt_size on VF RX queue

Jonathan Davies <[email protected]>
net: virtio_net_hdr_to_skb: count transport header in UFO

Pavel Skripkin <[email protected]>
net: dpaa2-eth: fix use-after-free in dpaa2_eth_remove

Xin Long <[email protected]>
net: sched: act_mirred: drop dst for the direction from egress to ingress

Mike Christie <[email protected]>
scsi: core: sysfs: Fix hang when device state is set via sysfs

Christophe JAILLET <[email protected]>
platform/x86: hp_accel: Fix an error handling path in 'lis3lv02d_probe()'

Randy Dunlap <[email protected]>
mips: lantiq: add support for clk_get_parent()

Randy Dunlap <[email protected]>
mips: bcm63xx: add support for clk_get_parent()

Colin Ian King <[email protected]>
MIPS: generic/yamon-dt: fix uninitialized variable error

Surabhi Boob <[email protected]>
iavf: Fix for the false positive ASQ/ARQ errors while issuing VF reset

Mitch Williams <[email protected]>
iavf: validate pointers

Jacob Keller <[email protected]>
iavf: prevent accidental free of filter structure

Piotr Marczak <[email protected]>
iavf: Fix failure to exit out from last all-multicast mode

Nicholas Nunley <[email protected]>
iavf: free q_vectors before queues in iavf_disable_vf

Nicholas Nunley <[email protected]>
iavf: check for null in iavf_fix_features

Pavel Skripkin <[email protected]>
net: bnx2x: fix variable dereferenced before check

James Clark <[email protected]>
perf tests: Remove bash construct from record+zstd_comp_decomp.sh

Sohaib Mohamed <[email protected]>
perf bench futex: Fix memory leak of perf_cpu_map__new()

Ian Rogers <[email protected]>
perf bpf: Avoid memory leak from perf_env__insert_btf()

Leon Romanovsky <[email protected]>
RDMA/netlink: Add __maybe_unused to static inline in C file

Masami Hiramatsu <[email protected]>
tracing/histogram: Do not copy the fixed-size char array field over the field size

Tom Zanussi <[email protected]>
tracing: Save normal string variables

Vincent Donnefort <[email protected]>
sched/core: Mitigate race cpus_share_cache()/update_top_cache_domain()

Randy Dunlap <[email protected]>
mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set

Dmitry Baryshkov <[email protected]>
clk: qcom: gcc-msm8996: Drop (again) gcc_aggre1_pnoc_ahb_clk

Joel Stanley <[email protected]>
clk/ast2600: Fix soc revision for AHB

Paul Cercueil <[email protected]>
clk: ingenic: Fix bugs with divided dividers

Randy Dunlap <[email protected]>
sh: define __BIG_ENDIAN for math-emu

Randy Dunlap <[email protected]>
sh: math-emu: drop unused functions

Randy Dunlap <[email protected]>
sh: fix kconfig unmet dependency warning for FRAME_POINTER

Gao Xiang <[email protected]>
f2fs: fix up f2fs_lookup tracepoints

Lu Wei <[email protected]>
maple: fix wrong return value of maple_bus_init().

Nick Desaulniers <[email protected]>
sh: check return code of request_irq

Michael Ellerman <[email protected]>
powerpc/dcr: Use cmplwi instead of 3-argument cmpli

Chengfeng Ye <[email protected]>
ALSA: gus: fix null pointer dereference on pointer block

Anatolij Gustschin <[email protected]>
powerpc/5200: dts: fix memory node unit name

Teng Qi <[email protected]>
iio: imu: st_lsm6dsx: Avoid potential array overflow in st_lsm6dsx_set_odr()

Mike Christie <[email protected]>
scsi: target: Fix alua_tg_pt_gps_count tracking

Mike Christie <[email protected]>
scsi: target: Fix ordered tag handling

Bart Van Assche <[email protected]>
MIPS: sni: Fix the build

Guanghui Feng <[email protected]>
tty: tty_buffer: Fix the softlockup issue in flush_to_ldisc

Randy Dunlap <[email protected]>
ALSA: ISA: not for M68K

Li Yang <[email protected]>
ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" compatible for flash

Li Yang <[email protected]>
ARM: dts: ls1021a: move thermal-zones node out of soc/

Yang Yingliang <[email protected]>
usb: host: ohci-tmio: check return value after calling platform_get_resource()

Roger Quadros <[email protected]>
ARM: dts: omap: fix gpmc,mux-add-data type

Luis Chamberlain <[email protected]>
firmware_loader: fix pre-allocated buf built-in firmware use

Guo Zhi <[email protected]>
scsi: advansys: Fix kernel pointer leak

Hans de Goede <[email protected]>
ASoC: nau8824: Add DMI quirk mechanism for active-high jack-detect

Stefan Riedmueller <[email protected]>
clk: imx: imx6ul: Move csi_sel mux to correct base register

Pierre-Louis Bossart <[email protected]>
ASoC: SOF: Intel: hda-dai: fix potential locking issue

Michael Walle <[email protected]>
arm64: dts: freescale: fix arm,sp805 compatible string

Stephan Gerhold <[email protected]>
arm64: dts: qcom: msm8916: Add unit name for /soc node

AngeloGioacchino Del Regno <[email protected]>
arm64: dts: qcom: msm8998: Fix CPU/L2 idle state latency and residency

Sven Peter <[email protected]>
usb: typec: tipd: Remove WARN_ON in tps6598x_block_read

Yang Yingliang <[email protected]>
usb: musb: tusb6010: check return value after calling platform_get_resource()

Selvin Xavier <[email protected]>
RDMA/bnxt_re: Check if the vlan is valid before reporting

Michael Walle <[email protected]>
arm64: dts: hisilicon: fix arm,sp805 compatible string

James Smart <[email protected]>
scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq()

Matthew Hagan <[email protected]>
ARM: dts: NSP: Fix mpcore, mmc node names

Michal Simek <[email protected]>
arm64: zynqmp: Fix serial compatible string

Amit Kumar Mahapatra <[email protected]>
arm64: zynqmp: Do not duplicate flash partition label property


-------------

Diffstat:

Makefile | 4 +-
arch/arm/boot/dts/bcm-nsp.dtsi | 4 +-
arch/arm/boot/dts/ls1021a-tsn.dts | 2 +-
arch/arm/boot/dts/ls1021a.dtsi | 66 ++++-----
arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi | 2 +-
arch/arm/boot/dts/omap3-overo-tobiduo-common.dtsi | 2 +-
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 16 +--
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 16 +--
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 +-
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8998.dtsi | 20 +--
.../boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dts | 4 +-
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +-
arch/arm64/kernel/vdso32/Makefile | 3 +-
arch/hexagon/lib/io.c | 4 +
arch/mips/Kconfig | 3 +
arch/mips/bcm63xx/clk.c | 6 +
arch/mips/generic/yamon-dt.c | 2 +-
arch/mips/lantiq/clk.c | 6 +
arch/mips/sni/time.c | 4 +-
arch/powerpc/boot/dts/charon.dts | 2 +-
arch/powerpc/boot/dts/digsy_mtc.dts | 2 +-
arch/powerpc/boot/dts/lite5200.dts | 2 +-
arch/powerpc/boot/dts/lite5200b.dts | 2 +-
arch/powerpc/boot/dts/media5200.dts | 2 +-
arch/powerpc/boot/dts/mpc5200b.dtsi | 2 +-
arch/powerpc/boot/dts/o2d.dts | 2 +-
arch/powerpc/boot/dts/o2d.dtsi | 2 +-
arch/powerpc/boot/dts/o2dnt2.dts | 2 +-
arch/powerpc/boot/dts/o3dnt.dts | 2 +-
arch/powerpc/boot/dts/pcm032.dts | 2 +-
arch/powerpc/boot/dts/tqm5200.dts | 2 +-
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 +-
arch/powerpc/sysdev/dcr-low.S | 2 +-
arch/s390/include/asm/kexec.h | 6 +
arch/s390/kernel/ipl.c | 3 +-
arch/s390/kernel/machine_kexec_file.c | 18 ++-
arch/sh/Kconfig.debug | 1 +
arch/sh/include/asm/sfp-machine.h | 8 ++
arch/sh/kernel/cpu/sh4a/smp-shx3.c | 5 +-
arch/sh/math-emu/math.c | 103 -------------
arch/x86/events/intel/uncore_snbep.c | 4 +
arch/x86/hyperv/hv_init.c | 3 +
drivers/base/firmware_loader/main.c | 13 +-
drivers/clk/clk-ast2600.c | 12 +-
drivers/clk/imx/clk-imx6ul.c | 2 +-
drivers/clk/ingenic/cgu.c | 6 +-
drivers/clk/qcom/gcc-msm8996.c | 15 --
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 11 ++
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
.../gpu/drm/nouveau/nvkm/engine/disp/hdmigv100.c | 1 -
drivers/gpu/drm/udl/udl_connector.c | 2 +-
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +-
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 12 +-
.../net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h | 4 +-
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 +-
drivers/net/ethernet/intel/i40e/i40e.h | 2 +
drivers/net/ethernet/intel/i40e/i40e_main.c | 160 +++++++++++++--------
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 70 +++------
drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 13 +-
drivers/net/ethernet/intel/iavf/iavf_main.c | 14 +-
drivers/net/ethernet/intel/ice/ice_main.c | 3 -
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 +-
drivers/net/tun.c | 5 +
drivers/platform/x86/hp_accel.c | 2 +
drivers/scsi/advansys.c | 4 +-
drivers/scsi/lpfc/lpfc_sli.c | 1 +
drivers/scsi/scsi_sysfs.c | 30 ++--
drivers/sh/maple/maple.c | 5 +-
drivers/target/target_core_alua.c | 1 -
drivers/target/target_core_device.c | 2 +
drivers/target/target_core_internal.h | 1 +
drivers/target/target_core_transport.c | 76 +++++++---
drivers/tty/tty_buffer.c | 3 +
drivers/usb/host/max3421-hcd.c | 25 +---
drivers/usb/host/ohci-tmio.c | 2 +-
drivers/usb/musb/tusb6010.c | 5 +
drivers/usb/typec/tps6598x.c | 2 +-
drivers/video/console/sticon.c | 12 +-
fs/btrfs/async-thread.c | 14 ++
fs/udf/dir.c | 32 ++++-
fs/udf/namei.c | 3 +
fs/udf/super.c | 2 +
include/asm-generic/tlb.h | 55 +++++--
include/linux/virtio_net.h | 7 +-
include/rdma/rdma_netlink.h | 2 +-
include/target/target_core_base.h | 6 +-
include/trace/events/f2fs.h | 12 +-
ipc/util.c | 6 +-
kernel/events/core.c | 10 +-
kernel/sched/core.c | 3 +
kernel/trace/trace_events_hist.c | 41 +++++-
mm/hugetlb.c | 23 ++-
mm/slab.h | 2 +-
net/batman-adv/fragmentation.c | 26 ++--
net/batman-adv/hard-interface.c | 3 +
net/nfc/core.c | 32 +++--
net/nfc/nci/core.c | 11 +-
net/sched/act_mirred.c | 11 +-
net/wireless/util.c | 1 +
sound/core/Makefile | 2 +
sound/isa/Kconfig | 2 +-
sound/isa/gus/gus_dma.c | 2 +
sound/pci/Kconfig | 1 +
sound/soc/codecs/nau8824.c | 40 ++++++
sound/soc/soc-dapm.c | 29 +++-
sound/soc/sof/intel/hda-dai.c | 7 +-
tools/perf/bench/futex-lock-pi.c | 1 +
tools/perf/bench/futex-requeue.c | 1 +
tools/perf/bench/futex-wake-parallel.c | 1 +
tools/perf/bench/futex-wake.c | 1 +
tools/perf/bench/sched-messaging.c | 4 +
tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
tools/perf/util/bpf-event.c | 6 +-
tools/perf/util/env.c | 5 +-
tools/perf/util/env.h | 2 +-
118 files changed, 779 insertions(+), 529 deletions(-)




2021-11-24 14:08:16

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.4 072/100] KVM: PPC: Book3S HV: Use GLOBAL_TOC for kvmppc_h_set_dabr/xdabr()

From: Michael Ellerman <[email protected]>

[ Upstream commit dae581864609d36fb58855fd59880b4941ce9d14 ]

kvmppc_h_set_dabr(), and kvmppc_h_set_xdabr() which jumps into
it, need to use _GLOBAL_TOC to setup the kernel TOC pointer, because
kvmppc_h_set_dabr() uses LOAD_REG_ADDR() to load dawr_force_enable.

When called from hcall_try_real_mode() we have the kernel TOC in r2,
established near the start of kvmppc_interrupt_hv(), so there is no
issue.

But they can also be called from kvmppc_pseries_do_hcall() which is
module code, so the access ends up happening with the kvm-hv module's
r2, which will not point at dawr_force_enable and could even cause a
fault.

With the current code layout and compilers we haven't observed a fault
in practice, the load hits somewhere in kvm-hv.ko and silently returns
some bogus value.

Note that we we expect p8/p9 guests to use the DAWR, but SLOF uses
h_set_dabr() to test if sc1 works correctly, see SLOF's
lib/libhvcall/brokensc1.c.

Fixes: c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option")
Signed-off-by: Michael Ellerman <[email protected]>
Reviewed-by: Daniel Axtens <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Sasha Levin <[email protected]>
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index f9c7326672b95..c9c6619564ffa 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -2535,7 +2535,7 @@ hcall_real_table:
.globl hcall_real_table_end
hcall_real_table_end:

-_GLOBAL(kvmppc_h_set_xdabr)
+_GLOBAL_TOC(kvmppc_h_set_xdabr)
EXPORT_SYMBOL_GPL(kvmppc_h_set_xdabr)
andi. r0, r5, DABRX_USER | DABRX_KERNEL
beq 6f
@@ -2545,7 +2545,7 @@ EXPORT_SYMBOL_GPL(kvmppc_h_set_xdabr)
6: li r3, H_PARAMETER
blr

-_GLOBAL(kvmppc_h_set_dabr)
+_GLOBAL_TOC(kvmppc_h_set_dabr)
EXPORT_SYMBOL_GPL(kvmppc_h_set_dabr)
li r5, DABRX_USER | DABRX_KERNEL
3:
--
2.33.0




2021-11-24 14:08:29

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.4 100/100] hugetlbfs: flush TLBs correctly after huge_pmd_unshare

From: Nadav Amit <[email protected]>

commit a4a118f2eead1d6c49e00765de89878288d4b890 upstream.

When __unmap_hugepage_range() calls to huge_pmd_unshare() succeed, a TLB
flush is missing. This TLB flush must be performed before releasing the
i_mmap_rwsem, in order to prevent an unshared PMDs page from being
released and reused before the TLB flush took place.

Arguably, a comprehensive solution would use mmu_gather interface to
batch the TLB flushes and the PMDs page release, however it is not an
easy solution: (1) try_to_unmap_one() and try_to_migrate_one() also call
huge_pmd_unshare() and they cannot use the mmu_gather interface; and (2)
deferring the release of the page reference for the PMDs page until
after i_mmap_rwsem is dropeed can confuse huge_pmd_unshare() into
thinking PMDs are shared when they are not.

Fix __unmap_hugepage_range() by adding the missing TLB flush, and
forcing a flush when unshare is successful.

Fixes: 24669e58477e ("hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages)" # 3.6
Signed-off-by: Nadav Amit <[email protected]>
Reviewed-by: Mike Kravetz <[email protected]>
Cc: Aneesh Kumar K.V <[email protected]>
Cc: KAMEZAWA Hiroyuki <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
mm/hugetlb.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)

--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3589,6 +3589,7 @@ void __unmap_hugepage_range(struct mmu_g
struct hstate *h = hstate_vma(vma);
unsigned long sz = huge_page_size(h);
struct mmu_notifier_range range;
+ bool force_flush = false;

WARN_ON(!is_vm_hugetlb_page(vma));
BUG_ON(start & ~huge_page_mask(h));
@@ -3617,10 +3618,8 @@ void __unmap_hugepage_range(struct mmu_g
ptl = huge_pte_lock(h, mm, ptep);
if (huge_pmd_unshare(mm, &address, ptep)) {
spin_unlock(ptl);
- /*
- * We just unmapped a page of PMDs by clearing a PUD.
- * The caller's TLB flush range should cover this area.
- */
+ tlb_flush_pmd_range(tlb, address & PUD_MASK, PUD_SIZE);
+ force_flush = true;
continue;
}

@@ -3677,6 +3676,22 @@ void __unmap_hugepage_range(struct mmu_g
}
mmu_notifier_invalidate_range_end(&range);
tlb_end_vma(tlb, vma);
+
+ /*
+ * If we unshared PMDs, the TLB flush was not recorded in mmu_gather. We
+ * could defer the flush until now, since by holding i_mmap_rwsem we
+ * guaranteed that the last refernece would not be dropped. But we must
+ * do the flushing before we return, as otherwise i_mmap_rwsem will be
+ * dropped and the last reference to the shared PMDs page might be
+ * dropped as well.
+ *
+ * In theory we could defer the freeing of the PMD pages as well, but
+ * huge_pmd_unshare() relies on the exact page_count for the PMD page to
+ * detect sharing, so we cannot defer the release of the page either.
+ * Instead, do flush now.
+ */
+ if (force_flush)
+ tlb_flush_mmu_tlbonly(tlb);
}

void __unmap_hugepage_range_final(struct mmu_gather *tlb,



2021-11-24 15:40:24

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

On Wed, Nov 24, 2021 at 12:57:16PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.162 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> Anything received after that time might be too late.
>

arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5: ERROR (duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on /soc/codec and /soc@0/codec
ERROR: Input tree has errors, aborting (use -f to force output)

Guenter

2021-11-24 15:40:52

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

On Wed, 24 Nov 2021 at 18:19, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.4.162 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.162-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Regression found on arm64 gcc-11 builds
Following build warnings / errors reported on stable-rc 5.4.


builds/linux/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5:
ERROR (duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on
/soc/codec and /soc@0/codec
ERROR: Input tree has errors, aborting (use -f to force output)
make[3]: *** [scripts/Makefile.lib:285:
arch/arm64/boot/dts/qcom/apq8016-sbc.dtb] Error 2


The bisect tool pointed to,

b979ffa8bbd6e4c33df7f3e7ac3d63f2234c023c is the first bad commit
commit b979ffa8bbd6e4c33df7f3e7ac3d63f2234c023c
Author: Stephan Gerhold <[email protected]>
Date: Tue Sep 21 17:21:18 2021 +0200

arm64: dts: qcom: msm8916: Add unit name for /soc node



As it was reported here,
https://lore.kernel.org/stable/CA+G9fYv5fnntoa1vzXp52=TSxCK=U8fV8J-AbE+WmKH1w4ebwg@mail.gmail.com/

Reported-by: Linux Kernel Functional Testing <[email protected]>

--
Linaro LKFT
https://lkft.linaro.org

2021-11-24 16:16:27

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

On Wed, Nov 24, 2021 at 07:40:17AM -0800, Guenter Roeck wrote:
> On Wed, Nov 24, 2021 at 12:57:16PM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.162 release.
> > There are 100 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> > Anything received after that time might be too late.
> >
>
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5: ERROR (duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on /soc/codec and /soc@0/codec
> ERROR: Input tree has errors, aborting (use -f to force output)

Will go drop the offending patch, thanks.

greg k-h

2021-11-24 16:16:40

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

On Wed, Nov 24, 2021 at 09:10:35PM +0530, Naresh Kamboju wrote:
> On Wed, 24 Nov 2021 at 18:19, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 5.4.162 release.
> > There are 100 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.162-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Regression found on arm64 gcc-11 builds
> Following build warnings / errors reported on stable-rc 5.4.
>
>
> builds/linux/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5:
> ERROR (duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on
> /soc/codec and /soc@0/codec
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[3]: *** [scripts/Makefile.lib:285:
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtb] Error 2
>
>
> The bisect tool pointed to,
>
> b979ffa8bbd6e4c33df7f3e7ac3d63f2234c023c is the first bad commit
> commit b979ffa8bbd6e4c33df7f3e7ac3d63f2234c023c
> Author: Stephan Gerhold <[email protected]>
> Date: Tue Sep 21 17:21:18 2021 +0200
>
> arm64: dts: qcom: msm8916: Add unit name for /soc node
>
>
>
> As it was reported here,
> https://lore.kernel.org/stable/CA+G9fYv5fnntoa1vzXp52=TSxCK=U8fV8J-AbE+WmKH1w4ebwg@mail.gmail.com/
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>

Now dropped, thanks.

greg k-h

2021-11-24 21:10:33

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

Hi Greg,

On Wed, Nov 24, 2021 at 2:10 PM Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.4.162 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> Anything received after that time might be too late.

Just a quick note, my arm64 builds are failing with the error:
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5: ERROR
(duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on
/soc/codec and /soc@0/codec

I have not yet tested, but I think it will be for:
f4850fe1a15d (\"arm64: dts: qcom: msm8916: Add unit name for /soc node\")


--
Regards
Sudip

2021-11-25 02:05:56

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

On Wed, Nov 24, 2021 at 12:57:16PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.162 release.
> There are 100 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 157 pass: 155 fail: 2
Failed builds:
arm64:defconfig
arm64:allmodconfig
Qemu test results:
total: 446 pass: 402 fail: 44
Failed tests:
<all arm64>
<all arm64be>

arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5: ERROR (duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on /soc/codec and /soc@0/codec

Guenter

2021-11-25 08:52:14

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/100] 5.4.162-rc1 review

On Wed, Nov 24, 2021 at 09:09:53PM +0000, Sudip Mukherjee wrote:
> Hi Greg,
>
> On Wed, Nov 24, 2021 at 2:10 PM Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 5.4.162 release.
> > There are 100 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 26 Nov 2021 11:56:36 +0000.
> > Anything received after that time might be too late.
>
> Just a quick note, my arm64 builds are failing with the error:
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:412.21-414.5: ERROR
> (duplicate_label): /soc/codec: Duplicate label 'lpass_codec' on
> /soc/codec and /soc@0/codec
>
> I have not yet tested, but I think it will be for:
> f4850fe1a15d (\"arm64: dts: qcom: msm8916: Add unit name for /soc node\")
>

I have dropped the offending commit now, thanks.

greg k-h