2021-12-04 13:18:28

by Stefan Wahren

Subject: [PATCH RFC V2 3/4] net: introduce media selection IF_PORT_HOMEPLUG

Introduce a new media selection dedicated for HomePlug powerline
communication. This allows us to use the proper if_port setting in
HomePlug drivers.

Suggested-by: Andrew Lunn <[email protected]>
Signed-off-by: Stefan Wahren <[email protected]>
---
include/uapi/linux/netdevice.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/netdevice.h b/include/uapi/linux/netdevice.h
index f3770c5..0f1f536 100644
--- a/include/uapi/linux/netdevice.h
+++ b/include/uapi/linux/netdevice.h
@@ -53,7 +53,8 @@ enum {
IF_PORT_AUI,
IF_PORT_100BASET,
IF_PORT_100BASETX,
- IF_PORT_100BASEFX
+ IF_PORT_100BASEFX,
+ IF_PORT_HOMEPLUG
};

/* hardware address assignment types */
--
2.7.4

2021-12-06 19:30:00

by Jakub Kicinski

Subject: Re: [PATCH RFC V2 3/4] net: introduce media selection IF_PORT_HOMEPLUG

On Sat, 4 Dec 2021 14:17:50 +0100 Stefan Wahren wrote:
> Introduce a new media selection dedicated for HomePlug powerline
> communication. This allows us to use the proper if_port setting in
> HomePlug drivers.
>
> Suggested-by: Andrew Lunn <[email protected]>
> Signed-off-by: Stefan Wahren <[email protected]>

I _think_ the IF_PORT API is an very ancient (Linux 2.2) way of
switching ports on early Ethernet cards. Isn't it? It predates
ethtool and all the modern interfaces. Quick grep seems to indicate
it's accessed only for old HW as well.

Do you have a use case for setting it?

> diff --git a/include/uapi/linux/netdevice.h b/include/uapi/linux/netdevice.h
> index f3770c5..0f1f536 100644
> --- a/include/uapi/linux/netdevice.h
> +++ b/include/uapi/linux/netdevice.h
> @@ -53,7 +53,8 @@ enum {
> IF_PORT_AUI,
> IF_PORT_100BASET,
> IF_PORT_100BASETX,
> - IF_PORT_100BASEFX
> + IF_PORT_100BASEFX,
> + IF_PORT_HOMEPLUG
> };
>
> /* hardware address assignment types */

2021-12-08 16:55:41

by Stefan Wahren

Subject: Re: [PATCH RFC V2 3/4] net: introduce media selection IF_PORT_HOMEPLUG

Am 06.12.21 um 20:29 schrieb Jakub Kicinski:
> On Sat, 4 Dec 2021 14:17:50 +0100 Stefan Wahren wrote:
>> Introduce a new media selection dedicated for HomePlug powerline
>> communication. This allows us to use the proper if_port setting in
>> HomePlug drivers.
>>
>> Suggested-by: Andrew Lunn <[email protected]>
>> Signed-off-by: Stefan Wahren <[email protected]>
> I _think_ the IF_PORT API is an very ancient (Linux 2.2) way of
> switching ports on early Ethernet cards. Isn't it? It predates
> ethtool and all the modern interfaces. Quick grep seems to indicate
> it's accessed only for old HW as well.
>
> Do you have a use case for setting it?
Actually not, i will drop it from the patchset.