2021-12-12 03:24:50

by Jason Wang

[permalink] [raw]

Subject: [PATCH] xen/pciback: fix typo in a comment

---

The double `the' in the comment in line 163 is repeated. Remove it
from the comment.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/xen/xen-pciback/pciback_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 3fbc21466a93..e38b43b5065e 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -160,7 +160,7 @@ int xen_pcibk_enable_msi(struct xen_pcibk_device *pdev,
}

/* The value the guest needs is actually the IDT vector, not the
- * the local domain's IRQ number. */
+ * local domain's IRQ number. */

op->value = dev->irq ? xen_pirq_from_irq(dev->irq) : 0;

--
2.34.1

2021-12-15 08:55:43

by Jürgen Groß

[permalink] [raw]

Subject: Re: [PATCH] xen/pciback: fix typo in a comment

---

On 12.12.21 04:24, Jason Wang wrote:
> The double `the' in the comment in line 163 is repeated. Remove it
> from the comment.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/xen/xen-pciback/pciback_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 3fbc21466a93..e38b43b5065e 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -160,7 +160,7 @@ int xen_pcibk_enable_msi(struct xen_pcibk_device *pdev,
> }
>
> /* The value the guest needs is actually the IDT vector, not the
> - * the local domain's IRQ number. */
> + * local domain's IRQ number. */

When touching this comment, would you mind to correct its style, too?
It should have a leading "/*" and a trailing "*/" line like e.g. in
line 72 of the same source file.


Juergen

---

Attachments:

OpenPGP_0xB0DE9DD628BF132F.asc (3.02 kB)
OpenPGP public key OpenPGP_signature (495.00 B)
OpenPGP digital signature Download all attachments