2021-12-12 03:20:14

by Jason Wang

Subject: [PATCH] fpga: stratix10-soc: fix typo in a comment

The double `if' in the comment in line 288 is repeated. Remove one
of them from the comment.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/fpga/stratix10-soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 357cea58ec98..e4f2e83a615b 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,

/*
* Loop waiting for buffers to be returned. When a buffer is returned,
- * reuse it to send more data or free if if all data has been sent.
+ * reuse it to send more data or free if all data has been sent.
*/
while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
reinit_completion(&priv->status_return_completion);
--
2.34.1

2021-12-12 16:19:08

by Tom Rix

Subject: Re: [PATCH] fpga: stratix10-soc: fix typo in a comment

On 12/11/21 7:19 PM, Jason Wang wrote:
> The double `if' in the comment in line 288 is repeated. Remove one
> of them from the comment.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/fpga/stratix10-soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..e4f2e83a615b 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
>
> /*
> * Loop waiting for buffers to be returned. When a buffer is returned,
> - * reuse it to send more data or free if if all data has been sent.
> + * reuse it to send more data or free if all data has been sent.

This looks fine.

Reviewed-by: Tom Rix <[email protected]>

> */
> while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
> reinit_completion(&priv->status_return_completion);

2021-12-13 01:36:15

by Xu Yilun

Subject: Re: [PATCH] fpga: stratix10-soc: fix typo in a comment

On Sun, Dec 12, 2021 at 08:19:00AM -0800, Tom Rix wrote:
>
> On 12/11/21 7:19 PM, Jason Wang wrote:
> > The double `if' in the comment in line 288 is repeated. Remove one
> > of them from the comment.
> >
> > Signed-off-by: Jason Wang <[email protected]>
> > ---
> > drivers/fpga/stratix10-soc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 357cea58ec98..e4f2e83a615b 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
> > /*
> > * Loop waiting for buffers to be returned. When a buffer is returned,
> > - * reuse it to send more data or free if if all data has been sent.
> > + * reuse it to send more data or free if all data has been sent.
>
> This looks fine.
>
> Reviewed-by: Tom Rix <[email protected]>

Acked-by: Xu Yilun <[email protected]>

Thanks,
Yilun

>
> > */
> > while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
> > reinit_completion(&priv->status_return_completion);