2021-12-21 19:38:03

by Colin Ian King

Subject: [PATCH] netfilter: nft_set_pipapo_avx2: remove redundant pointer lt

The pointer lt is being assigned a value and then later
updated but that value is never read. The pointer is
redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
net/netfilter/nft_set_pipapo_avx2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/netfilter/nft_set_pipapo_avx2.c b/net/netfilter/nft_set_pipapo_avx2.c
index 6f4116e72958..52e0d026d30a 100644
--- a/net/netfilter/nft_set_pipapo_avx2.c
+++ b/net/netfilter/nft_set_pipapo_avx2.c
@@ -1048,11 +1048,9 @@ static int nft_pipapo_avx2_lookup_slow(unsigned long *map, unsigned long *fill,
struct nft_pipapo_field *f, int offset,
const u8 *pkt, bool first, bool last)
{
- unsigned long *lt = f->lt, bsize = f->bsize;
+ unsigned long bsize = f->bsize;
int i, ret = -1, b;

- lt += offset * NFT_PIPAPO_LONGS_PER_M256;
-
if (first)
memset(map, 0xff, bsize * sizeof(*map));

--
2.33.1

2021-12-24 16:03:35

by Pablo Neira Ayuso

Subject: Re: [PATCH] netfilter: nft_set_pipapo_avx2: remove redundant pointer lt

On Tue, Dec 21, 2021 at 07:37:57PM +0000, Colin Ian King wrote:
> The pointer lt is being assigned a value and then later
> updated but that value is never read. The pointer is
> redundant and can be removed.

Applied to nf-next, thanks