2021-12-21 21:35:58

by Prabhakar Mahadev Lad

Subject: [PATCH] mfd: ab8500-core: Use platform_get_irq() to get the interrupt

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <[email protected]>
---
Hi,

Usage of platform_get_irq() was agreed based on the discussion [0].

[0] https://patchwork.kernel.org/project/linux-renesas-soc/
patch/[email protected]/

Cheers,
Prabhakar
---
drivers/mfd/ab8500-core.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index cca0aac26148..1e61c3dacb0d 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -1042,7 +1042,6 @@ static int ab8500_probe(struct platform_device *pdev)
enum ab8500_version version = AB8500_VERSION_UNDEFINED;
struct device_node *np = pdev->dev.of_node;
struct ab8500 *ab8500;
- struct resource *resource;
int ret;
int i;
u8 value;
@@ -1053,13 +1052,9 @@ static int ab8500_probe(struct platform_device *pdev)

ab8500->dev = &pdev->dev;

- resource = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (!resource) {
- dev_err(&pdev->dev, "no IRQ resource\n");
- return -ENODEV;
- }
-
- ab8500->irq = resource->start;
+ ab8500->irq = platform_get_irq(pdev, 0);
+ if (ab8500->irq < 0)
+ return ab8500->irq;

ab8500->read = ab8500_prcmu_read;
ab8500->write = ab8500_prcmu_write;
--
2.17.1

2021-12-22 02:51:29

by Linus Walleij

Subject: Re: [PATCH] mfd: ab8500-core: Use platform_get_irq() to get the interrupt

On Tue, Dec 21, 2021 at 10:35 PM Lad Prabhakar
<[email protected]> wrote:

> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij