2021-12-24 10:45:38

by Potin Lai

Subject: [PATCH 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq

Add support for winbond w25q01jv-iq chip

Signed-off-by: Potin Lai <[email protected]>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index c783ab4ba1e4..a2a72d05fc28 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -104,6 +104,8 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+ { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
};

/**
--
2.17.1

2021-12-27 09:02:33

by Pratyush Yadav

Subject: Re: [PATCH 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq

On 24/12/21 06:45PM, Potin Lai wrote:
> Add support for winbond w25q01jv-iq chip
>
> Signed-off-by: Potin Lai <[email protected]>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index c783ab4ba1e4..a2a72d05fc28 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -104,6 +104,8 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

We recently reworked how flags are set. Please use the new flags
variants. See [0] If the flash supports SFDP then we prefer you only set
the PARSE_SFDP flag. See [1].

You also need to show the dumps of the SFDP and other flash parameters.
See [2].

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/next&id=ec1c0e996035c8f93eca7bb64ccf0411b57fddea
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/next&id=1c513c986b0a4c7151cb4571e568136f16c9dc58
[2] https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

> };
>
> /**
> --
> 2.17.1
>

--
Regards,
Pratyush Yadav
Texas Instruments Inc.

2021-12-29 14:01:18

by Tudor Ambarus

Subject: Re: [PATCH 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq

On 12/27/21 11:01 AM, Pratyush Yadav wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 24/12/21 06:45PM, Potin Lai wrote:
>> Add support for winbond w25q01jv-iq chip
>>
>> Signed-off-by: Potin Lai <[email protected]>
>> ---
>> drivers/mtd/spi-nor/winbond.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index c783ab4ba1e4..a2a72d05fc28 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -104,6 +104,8 @@ static const struct flash_info winbond_parts[] = {
>> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
>> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
>> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>> + { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048,
>> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>
> We recently reworked how flags are set. Please use the new flags
> variants. See [0] If the flash supports SFDP then we prefer you only set
> the PARSE_SFDP flag. See [1].
>
> You also need to show the dumps of the SFDP and other flash parameters.
> See [2].
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/next&id=ec1c0e996035c8f93eca7bb64ccf0411b57fddea
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/next&id=1c513c986b0a4c7151cb4571e568136f16c9dc58
> [2] https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

Thanks for the guidance, Pratyush, your hints are correct.
I'm in the process of updating the documentation where I'm adding some
guidelines on how to submit a new flash proposal or how to update an
existing flash_info entry. We'll be able to guide contributors to the SPI NOR
documentation soon.

Cheers,
ta