2021-12-28 01:37:24

by Colin Ian King

Subject: [PATCH] ocfs2: remove redundant assignment to pointer root_bh

Pointer root_bh is being initialized with a value that is not read,
it is being re-assigned later on closer to its use. The early
initialization is redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
fs/ocfs2/alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index bb247bc349e4..bf9357123bc5 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -2040,7 +2040,7 @@ static void ocfs2_complete_edge_insert(handle_t *handle,
int i, idx;
struct ocfs2_extent_list *el, *left_el, *right_el;
struct ocfs2_extent_rec *left_rec, *right_rec;
- struct buffer_head *root_bh = left_path->p_node[subtree_index].bh;
+ struct buffer_head *root_bh;

/*
* Update the counts and position values within all the
--
2.33.1

2021-12-28 01:49:54

by Joseph Qi

Subject: Re: [PATCH] ocfs2: remove redundant assignment to pointer root_bh

On 12/28/21 9:37 AM, Colin Ian King wrote:
> Pointer root_bh is being initialized with a value that is not read,
> it is being re-assigned later on closer to its use. The early
> initialization is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Joseph Qi <[email protected]>
> ---
> fs/ocfs2/alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index bb247bc349e4..bf9357123bc5 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -2040,7 +2040,7 @@ static void ocfs2_complete_edge_insert(handle_t *handle,
> int i, idx;
> struct ocfs2_extent_list *el, *left_el, *right_el;
> struct ocfs2_extent_rec *left_rec, *right_rec;
> - struct buffer_head *root_bh = left_path->p_node[subtree_index].bh;
> + struct buffer_head *root_bh;
>
> /*
> * Update the counts and position values within all the