2022-01-15 17:27:33

by CGEL

Subject: [PATCH] drm/amdgpu: remove duplicate include

From: Changcheng Deng <[email protected]>

'drm/drm_drv.h' included in 'amdgpu_ttm.c' is duplicated. It is also
included on 53 line.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Changcheng Deng <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 953d68b26f0b..ebd40d1a8aff 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -43,7 +43,6 @@
#include <linux/sizes.h>
#include <linux/module.h>

-#include <drm/drm_drv.h>
#include <drm/ttm/ttm_bo_api.h>
#include <drm/ttm/ttm_bo_driver.h>
#include <drm/ttm/ttm_placement.h>
--
2.25.1

2022-01-17 15:56:59

by Christian König

Subject: Re: [PATCH] drm/amdgpu: remove duplicate include

Am 15.01.22 um 08:02 schrieb [email protected]:
> From: Changcheng Deng <[email protected]>
>
> 'drm/drm_drv.h' included in 'amdgpu_ttm.c' is duplicated. It is also
> included on 53 line.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Changcheng Deng <[email protected]>

Acked-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 953d68b26f0b..ebd40d1a8aff 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -43,7 +43,6 @@
> #include <linux/sizes.h>
> #include <linux/module.h>
>
> -#include <drm/drm_drv.h>
> #include <drm/ttm/ttm_bo_api.h>
> #include <drm/ttm/ttm_bo_driver.h>
> #include <drm/ttm/ttm_placement.h>
> --
> 2.25.1
>